[#1620] - Change list formfield to disable chosen when facing a huge amount of options
- Closed
- 4 Jun 2014
- Medium
- Build: master
- # 1620
- Diff
- Bakual:ListChosen3
- Foreign ID 31514
- Error default This pull request is targeted at the master branch. Pull requests should no longer be merged to master. Details
User tests: Successful: Unsuccessful:
See Feature Tracker:
http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=31514
Chosen has performance issues when facing a huge amount of options. Since the menu item view (like most views) use JHtml::_('formbehavior.chosen', 'select'); to load Chosen on every <select>, this can break the creation of menu items.
This PR makes use of the default behaviour of JHtml::_('formbehavior.chosen'); which triggers on the class .advancedSelect.
This PR will do a few things:
- Changing the list formfield so it defaults to the class "advancedSelect" if no class is given. Currently there is no default at all.
- Changing the list formfield so it removes this class if there are more than 10'000 options.
- Changing the call
JHtml::_('formbehavior.chosen', 'select');to use the defaultJHtml::_('formbehavior.chosen');in the menu item view.
Merged master without conflicts
Thanks Thomas! :)
The content of this PR could certainly be extended to other areas of the CMS.
However I kept it simple on purpose so it's easier to test and it adresses the main issue that was brought up in the google group.
Merged upstream master
@Bakual What are your thoughts on extending this PR to cover all JForm fields that are rendered as a select elements and all backend views of the CMS? This issue with Chosen seems to affect other views of the CMS and other JForm fields like type="menuitem" multiple="true".
@betweenbrain No objections from me to expand this. I initially did this because the issue was raised in the Google Group for this particular view.
@betweenbrain No objections from me to expand this. I initially did this because the issue was raised in the Google Group for this particular view.
I'm in favor of that and happy to help. Please let me know if I can do anything.
Hi Thomas,
Looks like this is out-of-sync. Could you update it to master?