User tests: Successful: Unsuccessful:
Status | New | ⇒ | Pending |
Category | ⇒ | Administration com_associations |
I have tested this item
Status | Pending | ⇒ | Ready to Commit |
Easy | No | ⇒ | Yes |
RTC after two successful tests.
I propose to modify this in order to get the correct icon in hathor.
this would be the code to modify
$bar = JToolbar::getInstance('toolbar');
$template = JFactory::getApplication()->getTemplate();
$icon = $template === 'hathor' ? 'icon-32-apply' : 'icon-apply';
$bar->appendButton(
'Custom', '<button onclick="Joomla.submitbutton(\'reference\')" '
. 'class="btn btn-small btn-success"><span class="' . $icon . ' icon-white" aria-hidden="true"></span>'
. JText::_('COM_ASSOCIATIONS_SAVE_REFERENCE') . '</button>', 'reference'
);
$bar->appendButton(
'Custom', '<button onclick="Joomla.submitbutton(\'target\')" '
. 'class="btn btn-small btn-success"><span class="' . $icon . ' icon-white" aria-hidden="true"></span>'
. JText::_('COM_ASSOCIATIONS_SAVE_TARGET') . '</button>', 'target'
);
@brianteeman Can you do?
is there really any point in doing that? I dont think so, hathor is dead and we have already stated that
any new features for Joomla will only be available with the Isis template
and associations is pretty much unusable anyway in hathor.
I just dont see the point in adding code that is more complicated when we have made that statement
I have to agree with @brianteeman lets face it hathor is a mess no matter what and making it that much more complex just to show an icon in a hardly used out dated theme is the least of hathors problem!
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-05-23 19:15:32 |
Closed_By | ⇒ | rdeutz | |
Labels |
Added:
?
|
Thanks
I have tested this item✅ successfully on 4263a64
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16199.