? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
22 May 2017

As seen in the images the code for the icons was incorrect. icon-32=* was only for hathor

before

screenshotr21-03-32

after

screenshotr21-03-00

avatar brianteeman brianteeman - open - 22 May 2017
avatar brianteeman brianteeman - change - 22 May 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 22 May 2017
Category Administration com_associations
avatar Quy
Quy - comment - 22 May 2017

I have tested this item successfully on 4263a64


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16199.

avatar Quy Quy - test_item - 22 May 2017 - Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 23 May 2017

I have tested this item successfully on 4263a64


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16199.

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 23 May 2017 - Tested successfully
avatar franz-wohlkoenig franz-wohlkoenig - change - 23 May 2017
Status Pending Ready to Commit
avatar franz-wohlkoenig franz-wohlkoenig - change - 23 May 2017
Easy No Yes
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 23 May 2017

RTC after two successful tests.

avatar infograf768
infograf768 - comment - 23 May 2017

I propose to modify this in order to get the correct icon in hathor.

this would be the code to modify

		$bar = JToolbar::getInstance('toolbar');

		$template = JFactory::getApplication()->getTemplate();
		$icon     = $template === 'hathor' ? 'icon-32-apply' : 'icon-apply';

		$bar->appendButton(
			'Custom', '<button onclick="Joomla.submitbutton(\'reference\')" '
			. 'class="btn btn-small btn-success"><span class="' . $icon . ' icon-white" aria-hidden="true"></span>'
			. JText::_('COM_ASSOCIATIONS_SAVE_REFERENCE') . '</button>', 'reference'
		);

		$bar->appendButton(
			'Custom', '<button onclick="Joomla.submitbutton(\'target\')" '
			. 'class="btn btn-small btn-success"><span class="' . $icon . ' icon-white" aria-hidden="true"></span>'
			. JText::_('COM_ASSOCIATIONS_SAVE_TARGET') . '</button>', 'target'
		);

@brianteeman Can you do?

avatar brianteeman
brianteeman - comment - 23 May 2017

is there really any point in doing that? I dont think so, hathor is dead and we have already stated that

any new features for Joomla will only be available with the Isis template

and associations is pretty much unusable anyway in hathor.

I just dont see the point in adding code that is more complicated when we have made that statement

avatar tonypartridge
tonypartridge - comment - 23 May 2017

I have to agree with @brianteeman lets face it hathor is a mess no matter what and making it that much more complex just to show an icon in a hardly used out dated theme is the least of hathors problem!

avatar rdeutz rdeutz - change - 23 May 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-05-23 19:15:32
Closed_By rdeutz
Labels Added: ?
avatar rdeutz rdeutz - close - 23 May 2017
avatar rdeutz rdeutz - merge - 23 May 2017
avatar brianteeman
brianteeman - comment - 23 May 2017

Thanks

Add a Comment

Login with GitHub to post a comment