@tonypartridge can you take a look into drone? http://213.160.72.75/joomla/joomla-cms/4442 ?

@zero-24 I was doing it just as you commented :-). All done, waiting for it to be re-tested it.

Can we please ensure there is a test on a multilanguage site - we might need to add this check to the if statement above it as well - just on code review. It might be ok.

I have tested this item ✅ successfully on 9398f56

Tested on a mongolanguage and multilanguage site. Seems to redirect correctly! Nice job!

@rdeutz we've had multiple trackers about this. I know it's last minute but it really should ship in 3.7.2 (even if that means we delay the release another day so the CMS release team have time)

I have tested this item ✅ successfully on 9398f56

RTC after two successful tests.

It is not enough to make sure this patch fixes a problem we also need to make sure it doesn't has a side effect. This need intensive testing.

Re 3.7.2, we are at the end of the release process, more or less hitting the publish button is missing, so this here is too late for 3.7.2.

Works fine on multilang.

I took a 3.6.5 web site and made the home page registered only AND made sure there was no login menu item
Loading the site on the front end I am taken to index.php/component/users/?view=login and can login

I upgraded the site to 3.7.1 and I get the "too many redirects" issue

I applied the patch and once again it is working and I am taken to index.php/component/users/?view=login and can login

So this is a successful test.

NOTE if you have a login menu item then you would not have needed this patch at all

I have tested this item ✅ successfully on 18bfbaf

@infograf768 could you please add a confirmed test if you have tested it on multilingual sites?

I have tested this item ✅ successfully on 18bfbaf

4 good tests - I'm merging this

I really dont see the need to rush this into 3.7.2 when it is easily fixed by anyone right now who has this issue by adding a login menu item and this can be added to the docs

3.7.2 packs are ready. Last night merges as well as this one will be in 3.7.3

whilst that is true @brianteeman It's about the people who upgrade their sites and have no clue about why their site has suddenly gone down with redirect loops. And another user in the original posts has tons of websites to update, doing so would cause them all to go down when he updates via the update manager.

@wilsonge was trying to get this into 372

We're not merging this into 3.7.2 - hence why I've merged it with a 3.7.3 milestone

@wilsonge our messages crossed in the ether ;)

Wondering why travis didn't run on this, on jenkins one unit test is falling

thanks! I see fix will be on 3.7.3 . OK will manually replace and fix the site until them

@tonypartridge
Please redo your PR. We have to make sure tests are not failing.

I blame @brianteeman 's language changes ;-) Will do it now.

they were in comments !!