Feeling Lucky
?
?
[#16192] - The group by isn't needed anymore
- Fixed in Code Base
- 20 Jun 2017
- Medium
- Build: staging
- # 16192
- Diff
- Bakual:RemoveSuperfluousGroupBy
User tests: Successful: Unsuccessful:
Cleanup PR to remove an unneeded group by clause
Summary of Changes
This PR removes the group by clause in FieldsModelFields. It's a leftover from #13302 and not needed anymore.
Testing Instructions
Test that no duplicate fields appear anywhere, especially when the field is assigned to multiple categories.
Expected result
No duplicates
Actual result
No duplicates
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_fields |
| Labels |
Added:
?
|
||
alikon
- comment
- 15 Jun 2017
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16192.
laoneo
- comment
- 15 Jun 2017
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16192.
| Status | Pending | ⇒ | Ready to Commit |
wilsonge
- comment
- 15 Jun 2017
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16192.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-06-20 11:16:51 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
?
|
||
@wilsonge if the pr #16187 get merged before this one, then the this fix is already applied on https://github.com/joomla/joomla-cms/pull/16187/files#diff-c9e1290961b6b06eeacf55ebb0d2f3acL217. Just in case you will get a merge conflict bringing this one into 4.