Feeling Lucky
?
[#16172] - [4.0] RFC Set default useragent on all JHttpFactory calls
- Closed
- 5 Jun 2017
- Medium
- Build: staging
- # 16172
Steps to reproduce the issue
RFC Set default useragent on all JHttpFactory calls.
Here: #15385 we did that for the updater but would it not make also sense to have this globaly for all calls using JHttpFactory ?
Expected result
default useragent on all JHttpFactory calls
Actual result
No useragent on JHttpFactory calls
joomla-cms-bot
- | Labels |
Added:
?
?
|
||
zero-24
- comment
- 21 May 2017
Sorry i meant JHttpFactory and not JHTTP i have just fixed the original issue.
zero-24
- comment
- 21 May 2017
fixed
| Title |
|
||||||
| Title |
|
||||||
franz-wohlkoenig
- | Category | ⇒ | Feature Request |
| Status | New | ⇒ | Discussion |
| Title |
|
||||||
| Status | Discussion | ⇒ | Closed | ||||
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-06-05 16:30:24 | ||||
| Closed_By | ⇒ | zero-24 | |||||
| Labels |
Removed:
?
|
||
IMO no,
JHttpshouldn't be forced to have a value here. If someone wants to set it inJHttpFactory, I think that'd be an OK compromise but unless it becomes a mandatory value to set for a request to be valid then I wouldn't force it in the adapter.