[#16165] - Fix indexer breaking words when they are partly enclosed via inline HTML tags
- Fixed in Code Base
- 22 Jul 2019
- Medium
- Build: staging
- # 16165
- Diff
- ggppdk:patch-31
- Success Hound No violations found. Woof! Details
- Success continuous-integration/drone/pr the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #7927
Summary of Changes
Currently HTML parser of the com_finder INDEXER is adding spaces after
the endings of all HTML tags so that words at edges of BLOCK Tags are spaced properly
but this destroys words partly enclosed via inline HTML tags!
e.g. with input:
<h1>Title</h1><p>Paragraph</p>
<strong>M</strong>obileTitle Paragraph ....... which is correct (block tags)
M oblie ....... which is broken, (inline tags)
This PR adds the space at the begining of the tags,
thus avoiding a costly / more costly regular expression to add it at the end !
Not all regular expressions are "performance evil", they can be very fast by e.g.
-- Starting with fixed texts, and also using OR on fixed texts
-- Also the performance of a regular expression can depend a lot on the input
Testing Instructions
- Test that words are spaced correctly for BLOCK tags and NOT SPACED for INLINE Tags
- Test that performance of indexer is not changed
Documentation Changes Required
None
Maybe add some more unit tests ? to have some test for inline tags too ?
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_finder |
| Labels |
Added:
?
|
||
I have tested this item
Before test Mobile not found
After test Mobile found
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16165.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16165.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16165.
@brianteeman can you please retest?
no need to retest as the only change was in a comment
| Status | Pending | ⇒ | Ready to Commit |
Status "Ready To Commit".
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-07-22 20:55:37 |
| Closed_By | ⇒ | HLeithner | |
| Labels |
Added:
?
|
||
thx
Please tell me if i have gotten the list of desired tags correctly