[#16159] - Smart-Search indexing with inline elements
- Closed
- 21 May 2017
- Medium
- Build: staging
- # 16159
- Diff
- brianteeman:smart-search
User tests: Successful: Unsuccessful:
Create an article with the following markup
<p><b>D</b>octor <b>W</b>ho</p>
<h1>Title</h1><p>Paragraph</p>
run smart search to create an index and then use the smart search module or component on the front end to perform the following searches
- Doctor
- Title
Expected behaviour
Doctor and Title are found
Actual behaviour
Only title is found because it has been indexed as D and octor
Apply PR
Both Doctor and Title are found
The search for title should result in Title paragraph with a space between them - this is test is to ensure that existing functionality before this pr has not been changed
Pull Request for Issue #7927 .
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_finder |
| Labels |
Added:
?
|
||
test are failing because after your change
<h1>Main title</h1>immediately followed by some text.
is converted to
Main titleimmediately followed by some text.
I have my doubts that you can make both cases work
That is because i believe the unit test is wrong and is testing invalid markup
H1 is a block element not an inline element so the failing line in the data for the unit test is wrong
<h1>Main title</h1>immediately followed by some text.
It should be something like
<h1>Main title</h1><p>immediately followed by some text.</p>
As any other markup is invalid
If you test the sample markup in the first post you will see that it passes correctly
<h1>Main title</h1>immediately followed by some text.
might be invalid but you would have the same effect with
<p><span class="IamABlockElement">Main title</span>immediately followed by some text.</p>
... css
.IamABlockElement {display:block}
The aim of the pr was to make the indexer work with valid markup
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-05-21 14:26:01 |
| Closed_By | ⇒ | brianteeman |
I am guessing that there should be unit tests for this ? @rdeutz but I wouldnt know where to start