[#16157] - mod_whosonline. Remove not existent param/variable linknames
- Fixed in Code Base
- 22 May 2017
- Medium
- Build: staging
- # 16157
- Diff
- bertmert:patch-15
User tests: Successful: Unsuccessful:
Summary of Changes
Removed variable $linknames because there's no parameter linknames and variable $linknames is not used anywhere later on.
Testing Instructions
- Code review. Search for
linknames.
mod_whosonline.xml:
https://github.com/joomla/joomla-cms/blob/staging/modules/mod_whosonline/mod_whosonline.xml
mod_whosonline.php:
https://github.com/joomla/joomla-cms/blob/staging/modules/mod_whosonline/mod_whosonline.php
helper.php:
https://github.com/joomla/joomla-cms/blob/staging/modules/mod_whosonline/helper.php
default php:
https://github.com/joomla/joomla-cms/blob/staging/modules/mod_whosonline/tmpl/default.php
- Test module (frontend). Nothing has changed.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Modules Front End |
| Title |
|
||||||
It's not a problem to not remove linknames from the database files (params field). I would prefer to keep this PR as-is or close it if adapting of sample datas is mandatory for merging it.
I have tested this item
Tested via code review.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16157.
I have tested this item
Code Review + Tested module in front end
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16157.
| Status | Pending | ⇒ | Ready to Commit |
RTC after two successful tests.
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-05-22 18:18:45 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
?
|
||
Just had a search and it was removed Dec 2011! here 557beb0
It is also added into the sample database under notes, it's also appearing under mod_users_latest not sure if that can be incorporated in this PR or another one opened.
The link I used to find the references in Joomla is https://github.com/joomla/joomla-cms/search?utf8=%E2%9C%93&q=linknames&type=
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16157.