Feeling Lucky
?
[#16143] - [tags] If we count false it returns 1 and not zero
- Closed
- 20 May 2017
- Medium
- Build: staging
- # 16143
- Diff
- zero-24:tags
User tests: Successful: Unsuccessful:
Pull Request for Issue #14747
Summary of Changes
$var = count(false) => 1 see: http://php.net/manual/en/function.count.php
@tonypartridge please check this too as this comes from #14747
Testing Instructions
- enable maximal error reporting
- add one article
- add one tag to a article
- access the article from the frontend
- get the URL for the list of the tagged articles
- untag the tag from the article
- see the error in the frontend
Notice: Trying to get property of non-object in JRoot\components\com_tags\views\tag\view.html.php on line 120
Expected result
No error just the No matching items were found. message
Actual result
The No matching items were found. plus a PHP notice: Notice: Trying to get property of non-object in JRoot\components\com_tags\views\tag\view.html.php on line 120
Documentation Changes Required
none
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | com_tags Front End |
wojsmol
- comment
- 20 May 2017
@Melvine9 If you tested this PR plese mark yuir test result on https://issues.joomla.org/tracker/joomla-cms/16143
PhilETaylor
-
Melvine9
- comment
- 20 May 2017
I have tested this item
Tested
PHP 7.1.5
The notice php fixed
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16143.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-05-20 19:18:30 |
| Closed_By | ⇒ | zero-24 | |
| Labels |
Added:
?
|
||
Thank you very much zero-24 . It's perfect ;-)