[#16140] - Fix invalid parsing UTF-8 attribute value
- Fixed in Code Base
- 22 May 2017
- Medium
- Build: staging
- # 16140
- Diff
- csthomas:fixfilter_utf8value
User tests: Successful: Unsuccessful:
Pull Request for Issue #16112
Summary of Changes
- Fix invalid parsing - use correct UTF-8 offset converted from
preg_match - This PR does not fix the performance issue
Testing Instructions
Unit test done it.
Please code review.
Expected result
Unit test pass
Actual result
Without the fix and with new unit test travis will hung up.
Documentation Changes Required
No
Note
Although I did this fix I'm not a fan of using any mb_ function in this methods.
I wish to remove it from filter code. I wish to find a more time to complete it in another PR.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries Unit Tests |
At all, it's just WOW! You reacted pretty fast and this big issue (at least for ME) is solved so quickly!
Thank you!
There were 2 issues reported in #16112,
a performance issue and a parsing issue,
both causing PHP execution timeouts,
and the first post on #16112 is due to the performance issue
here you are fixing the parsing issue (thanks for the fix !)
maybe update the description of this PR to clarify the above
| Title |
|
||||||
| Title |
|
||||||
| Title |
|
||||||
| Title |
|
||||||
| Title |
|
||||||
| Title |
|
||||||
Tested the https://github.com/joomla/joomla-cms/files/1014563/silkypixcameras.txt posted in #16112 to which I added a page break.
PHP 5.4.4
For a Manager it took 270 sec to save and close.
For a SuperAdmin 16 sec.
(Yes, I understand this PR will not solve the performance issue)
Obviously Manager was set to "Default Blacklist". Shall we therefore consider this as acceptable?
This PR fixes invalid parsing, for me it is a temporary fix, because more things should be changed.
Improving performance takes longer and I'm still working on it in a separate branch.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16140.
@franz-wohlkoenig This has 2 successful tests. Do you need @PepeLopez to mark it successful to make it official even thought she stated it is?
| Status | Pending | ⇒ | Ready to Commit |
RTC after two successful tests.
@Quy i altered Test of @PepeLopez
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-05-22 08:28:06 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
?
|
||
Looks good, and also seems to work properly,
but it is late night here, and my thinking is slow,
will post a successful test tommorow