?

Pending

User tests: Successful: Unsuccessful:

avatar csthomas
csthomas
19 May 2017

Pull Request for Issue #16112

Summary of Changes

  • Fix invalid parsing - use correct UTF-8 offset converted from preg_match
  • This PR does not fix the performance issue

Testing Instructions

Unit test done it.
Please code review.

Expected result

Unit test pass

Actual result

Without the fix and with new unit test travis will hung up.

Documentation Changes Required

No

Note

Although I did this fix I'm not a fan of using any mb_ function in this methods.
I wish to remove it from filter code. I wish to find a more time to complete it in another PR.

avatar csthomas csthomas - open - 19 May 2017
avatar csthomas csthomas - change - 19 May 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 19 May 2017
Category Libraries Unit Tests
avatar csthomas csthomas - change - 19 May 2017
The description was changed
avatar csthomas csthomas - edited - 19 May 2017
avatar ggppdk
ggppdk - comment - 19 May 2017

Looks good, and also seems to work properly,
but it is late night here, and my thinking is slow,
will post a successful test tommorow

avatar csthomas csthomas - change - 19 May 2017
The description was changed
avatar csthomas csthomas - edited - 19 May 2017
avatar PepeLopez
PepeLopez - comment - 19 May 2017

At all, it's just WOW! You reacted pretty fast and this big issue (at least for ME) is solved so quickly!
Thank you!

avatar ggppdk
ggppdk - comment - 19 May 2017

@csthomas

There were 2 issues reported in #16112,

a performance issue and a parsing issue,
both causing PHP execution timeouts,

and the first post on #16112 is due to the performance issue

here you are fixing the parsing issue (thanks for the fix !)

maybe update the description of this PR to clarify the above

avatar csthomas csthomas - change - 20 May 2017
The description was changed
avatar csthomas csthomas - edited - 20 May 2017
avatar csthomas csthomas - change - 20 May 2017
The description was changed
avatar csthomas csthomas - edited - 20 May 2017
avatar joomla-cms-bot joomla-cms-bot - change - 20 May 2017
Title
Fix UTF-8 attribute value
Fix UTF-8 attritute value
avatar joomla-cms-bot joomla-cms-bot - edited - 20 May 2017
avatar franz-wohlkoenig franz-wohlkoenig - change - 20 May 2017
Title
Fix UTF-8 attritute value
Fix UTF-8 attribute value
avatar joomla-cms-bot joomla-cms-bot - change - 20 May 2017
Title
Fix parsing issue UTF-8 attribute value
Fix UTF-8 attribute value
avatar joomla-cms-bot joomla-cms-bot - edited - 20 May 2017
avatar franz-wohlkoenig franz-wohlkoenig - change - 20 May 2017
Title
Fix UTF-8 attritute value
Fix parsing issue UTF-8 attribute value
avatar franz-wohlkoenig franz-wohlkoenig - change - 20 May 2017
Title
Fix UTF-8 attribute value
Fix parsing issue UTF-8 attribute value
avatar franz-wohlkoenig franz-wohlkoenig - change - 20 May 2017
Title
Fix parsing issue UTF-8 attribute value
Fix invalid parsing UTF-8 attribute value
avatar joomla-cms-bot joomla-cms-bot - edited - 20 May 2017
avatar infograf768
infograf768 - comment - 20 May 2017

Tested the https://github.com/joomla/joomla-cms/files/1014563/silkypixcameras.txt posted in #16112 to which I added a page break.

PHP 5.4.4
For a Manager it took 270 sec to save and close.
For a SuperAdmin 16 sec.

(Yes, I understand this PR will not solve the performance issue)

avatar infograf768
infograf768 - comment - 20 May 2017

Obviously Manager was set to "Default Blacklist". Shall we therefore consider this as acceptable?

avatar csthomas
csthomas - comment - 20 May 2017

This PR fixes invalid parsing, for me it is a temporary fix, because more things should be changed.
Improving performance takes longer and I'm still working on it in a separate branch.

avatar ggppdk
ggppdk - comment - 21 May 2017

I have tested this item successfully on db0b08a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16140.

avatar ggppdk ggppdk - test_item - 21 May 2017 - Tested successfully
avatar Quy
Quy - comment - 21 May 2017

@franz-wohlkoenig This has 2 successful tests. Do you need @PepeLopez to mark it successful to make it official even thought she stated it is?

avatar franz-wohlkoenig franz-wohlkoenig - alter_testresult - 21 May 2017 - PepeLopez: Tested successfully
avatar franz-wohlkoenig franz-wohlkoenig - change - 21 May 2017
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 21 May 2017

RTC after two successful tests.

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 21 May 2017

@Quy i altered Test of @PepeLopez

avatar rdeutz rdeutz - change - 22 May 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-05-22 08:28:06
Closed_By rdeutz
Labels Added: ?
avatar rdeutz rdeutz - close - 22 May 2017
avatar rdeutz rdeutz - merge - 22 May 2017

Add a Comment

Login with GitHub to post a comment