?

Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
19 May 2017

Pull Request for Issue #15564 .

Summary of Changes

Make sure that all the default options for com_users, com_contacts and com_content are set in the database at installation.
It didnt use to be that important but now that we read the default values to show what the global option is it is more important that they are set in the database without having to ask the user to save their options even if they havent changed anything

Testing Instructions

Perform a full install with this branch

avatar brianteeman brianteeman - open - 19 May 2017
avatar brianteeman brianteeman - change - 19 May 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 19 May 2017
Category SQL Installation Postgresql MS SQL
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 20 May 2017

are Basic Settings meant as default Options for com_users? If yes, they are not shown:
bildschirmfoto 2017-05-20 um 12 19 32

avatar rdeutz rdeutz - change - 27 May 2017
Labels Added: ?
avatar tonypartridge
tonypartridge - comment - 29 May 2017

@franz-wohlkoenig how do you mean? It's set to use default. Brian's change sets the default values, this is use default for instance. I.e. the Actively set backend template.

avatar tonypartridge
tonypartridge - comment - 29 May 2017

@brianteeman I've tested / reviewed this, what about date_format should we specify a default data_format value? i.e. D M Y as the value so users know how to use it (Without reading the tooltip) ;-)

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 29 May 2017

@tonypartridge reading brians, yours and my Comment – didn't get the point of all 3. So it looks like a lack of langugage.

avatar brianteeman
brianteeman - comment - 29 May 2017

@tonypartridge i created this by comparing the results of the db value after saving the options once.

avatar tonypartridge
tonypartridge - comment - 29 May 2017

Ok that's great then, we can leave as is.

avatar tonypartridge
tonypartridge - comment - 29 May 2017

I have tested this item successfully on 6520701

Tested as a fresh install and compared. values before and after.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16138.

avatar tonypartridge tonypartridge - test_item - 29 May 2017 - Tested successfully
avatar brianteeman
brianteeman - comment - 29 May 2017

@Quy applied that new param
can you and @tonypartridge retest please

avatar Quy
Quy - comment - 29 May 2017

I have tested this item successfully on 49851d0

Code review and tested with MySQL installation.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16138.

avatar Quy Quy - test_item - 29 May 2017 - Tested successfully
avatar brianteeman brianteeman - change - 14 Jun 2017
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2017-06-14 19:53:40
Closed_By brianteeman
avatar brianteeman brianteeman - close - 14 Jun 2017
avatar brianteeman brianteeman - change - 16 Aug 2017
Status Closed New
Closed_Date 2017-06-14 19:53:40
Closed_By brianteeman
avatar brianteeman brianteeman - change - 16 Aug 2017
Status New Pending
avatar brianteeman brianteeman - reopen - 16 Aug 2017
avatar brianteeman brianteeman - change - 16 Aug 2017
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2017-08-16 21:30:17
Closed_By brianteeman
avatar brianteeman brianteeman - close - 16 Aug 2017

Add a Comment

Login with GitHub to post a comment