? ? Pending

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
19 May 2017

Follow up on #16118

Summary of Changes

As title says

Testing Instructions

Make sure you use latest staging or patch first with #16118
Patch.

Expected result

No more language search tools filter as well as language column in the list when filtering by administrator

screen shot 2017-05-19 at 12 20 04

@franz-wohlkoenig @AlexRed
@rdeutz

avatar infograf768 infograf768 - open - 19 May 2017
avatar infograf768 infograf768 - change - 19 May 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 19 May 2017
Category Administration com_modules
avatar wilsonge
wilsonge - comment - 19 May 2017

Is there a reason we don't have language specific admin modules?

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 19 May 2017

I have tested this item successfully on 47ba9d3


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16124.

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 19 May 2017 - Tested successfully
avatar infograf768
infograf768 - comment - 19 May 2017

Language is no use in back-end as it is not multingual and we do not filter display of modules (in this case) by language.
Same btw with the new admin menus feature.

avatar brianteeman
brianteeman - comment - 19 May 2017

Then surely we should remove the language setting in all the admin modules

avatar brianteeman
brianteeman - comment - 19 May 2017

Thinking about it - it would appear to me that the bug is that we dont filter the display of modules in the administrator based on language. If we don't then the only way we can have translated module titles for example is to use the less than optimal automatic titles which override the title set by the user

avatar infograf768
infograf768 - comment - 19 May 2017

it would appear to me that the bug is that we dont filter the display of modules in the administrator based on language.

Bug? Not sure. Imagine backend modules filtered by language. What about an admin or superadmin access to these if their backend language is not the one used for some modules.

There is a possible other solution, it is using the access with specific groups, same as for the new admin menus. No need for language filtering here.

Then surely we should remove the language setting in all the admin modules

We can indeed, take off the language field from an admin module edit form.
It's quite easy. If you like I can add it to this PR.
We would get (the language field is, for site, between Ordering and Note):

screen shot 2017-05-19 at 15 17 06

avatar brianteeman
brianteeman - comment - 19 May 2017

As i said - on reflection i believe there should be the ability to filter modules on language

avatar infograf768
infograf768 - comment - 19 May 2017

I already replied that it makes no sense to do so in backend.

avatar brianteeman
brianteeman - comment - 19 May 2017

i disagree

avatar AlexRed
AlexRed - comment - 20 May 2017

I have tested this item successfully on 47ba9d3

Patch ok for me.
Good idea also take off the language field from an admin module edit form.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16124.

avatar AlexRed AlexRed - test_item - 20 May 2017 - Tested successfully
avatar franz-wohlkoenig franz-wohlkoenig - change - 20 May 2017
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 20 May 2017

RTC after two successful tests.

avatar infograf768
infograf768 - comment - 20 May 2017

will add taking off lang field from admin modules form after siesta. lets wait for rtc. ?

avatar brianteeman
brianteeman - comment - 20 May 2017

we have no way of knowing that this language field is not being used on non core admin templates. we cant just remove it just because the core templates dont use it

avatar infograf768 infograf768 - change - 20 May 2017
Labels Added: ?
avatar rdeutz
rdeutz - comment - 21 May 2017

The main question here is: Should the backend are multi language? Without the ability to have different admin menus I would clearly say no but it seems to me that we are going a path to make the backend also more configurable. Notwithstanding I think at the moment we not at the point to do all the other work for making the backend full multi language, I would say this is something we should reconsider for Joomla4. @wilsonge please take it from here :-)

avatar rdeutz rdeutz - change - 21 May 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-05-21 12:27:21
Closed_By rdeutz
Labels Added: ?
avatar rdeutz rdeutz - close - 21 May 2017
avatar rdeutz rdeutz - merge - 21 May 2017

Add a Comment

Login with GitHub to post a comment