[#16115] - [4.0]Remove manifest files and use existing XML info
- Closed
- 24 Jul 2017
- Medium
- Build: 4.0-dev
- # 16115
- Diff
- wilsonge:remove-manifest-v4
- Success continuous-integration/drone/pr the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Failure continuous-integration/appveyor/pr AppVeyor build failed Details
User tests: Successful: Unsuccessful:
Summary of Changes
This is the first (in hopefully a series) of a cleanup of the Installer classes in Joomla 4, with the aim to make extension installs much more consistent and the classes more manageable.
Testing Instructions
Ensure installing libraries and packages is unchanged from the current state in 4.x
Documentation Changes Required
Classes removed.
Additional Notes
If this works after testing then of course the relevant deprecations must be made in 3.x but I'm not 100% confident of these changes (it feels far too easy) so I want some tests from others first.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries Unit Tests |
| Labels |
Added:
?
?
|
||
| Title |
|
||||||
| Title |
|
||||||
For sure. As I said I just want testing because I can't believe I can delete this much code for adding an extra 5 lines into 2 files......
Note there are unit test fails unrelated to this PR because of an issue in the upstream framework application library - this is a general issue for the J4 branch - not something related to this PR
Tried installing extensions from Regular Labs and Akeeba, both of which return an alert, Internal Error and also tried with a custom package.
Same thing happes on 4.0-dev
Ajax repsonse is throwing this error:
Call to undefined method Joomla\CMS\Installer\Adapter\ModuleAdapter::get()
| Milestone |
Added: |
||
| Milestone |
Added: |
||
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-07-24 13:30:01 |
| Closed_By | ⇒ | wilsonge |
Forgot this was still open - me and Michael found a problem which meant (as is) this can't work for packages. I'll sit down and try again another day
ok thanks
Can you check your other open issues - maybe the same is true for some of them as well https://github.com/joomla/joomla-cms/pulls/wilsonge
updated the title to show it is for J4