[#16109] - Prevent Double amp escaping with htmlspecialchars bestpractice
- Fixed in Code Base
- 19 May 2017
- Medium
- Build: staging
- # 16109
- Diff
- mansour-gabteni:staging
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
adding bestpractice for htmlspecialchars because this standard have $double_encode = true by default
Actual result
links are wihtout & in url
Documentation Changes Required
modules/mod_menu/tmpl/default_url.php
modules/mod_menu/tmpl/default_component.php
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Modules Front End |
No, this PR basically puts back the htmlspecialchars() call and changes the parameters passed to it.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16109.
@PhilETaylor
Is that OK for you?
@infograf768 well its another way to crack a nut - yes, it works.
Arguably the htmlspecialchars call should/could move moved into the ampReplace method and there be a flag in the method signature to run htmlspecialchars before the amp replacement preg_match, this would improve the ampReplace method and make it more powerful and reusable.
I have tested this item
Doesn't seem to break the links which is good.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16109.
| Status | Pending | ⇒ | Ready to Commit |
2 good tests. rtc
@rdeutz good to merge
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16109.
This should be 3.7.2 because it was broke in a change in 3.7.x a7705bf#diff-17d077571f8b5fe34c3d9f7fec9a6e44
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-05-19 17:14:41 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
?
|
||
can you please Look at #16089 is this is a duplicate PR?