?
avatar oe1tkt
oe1tkt
17 May 2017

The issue

/libraries/legacy/view/legacy.php
inside comments (line 342) of function assignRef

   * <code>
   * $view = new JView;
   *
   * // Assign by name and value
   * $view->assignRef('var1', $ref);
   *
   * // Assign directly
   * $view->ref = &$var1;
   * </code>

Should be:

   * <code>
 * $view = new JView;
 *
 * // Assign by name and value
 * $view->assignRef('var1', $ref);
 *
 * // Assign directly
 * $view->var1 = &$ref;
 * </code>

Reason:

Inside the code, it is:

public function assignRef($key, &$val)
{ //...
		$this->$key = &$val;
 // ... 
}

Joomla core 3.7.0

for instance, a code snipped:

 		//deprecated: $this->assignRef('lists', $this->_lists); //changed to next line:
	$this->lists = &$this->_lists;
avatar oe1tkt oe1tkt - open - 17 May 2017
avatar joomla-cms-bot joomla-cms-bot - change - 17 May 2017
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 17 May 2017
avatar oe1tkt oe1tkt - edited - 17 May 2017
avatar oe1tkt oe1tkt - change - 17 May 2017
The description was changed
avatar oe1tkt oe1tkt - edited - 17 May 2017
avatar oe1tkt oe1tkt - change - 17 May 2017
The description was changed
avatar oe1tkt oe1tkt - edited - 17 May 2017
avatar oe1tkt oe1tkt - change - 17 May 2017
The description was changed
avatar oe1tkt oe1tkt - edited - 17 May 2017
avatar joomla-cms-bot joomla-cms-bot - change - 17 May 2017
The description was changed
avatar joomla-cms-bot joomla-cms-bot - edited - 17 May 2017
avatar franz-wohlkoenig franz-wohlkoenig - change - 17 May 2017
Build staging 3.7.0
avatar franz-wohlkoenig franz-wohlkoenig - change - 17 May 2017
Category Libraries
avatar brianteeman
brianteeman - comment - 19 May 2017

Could you submit a pull request to fix this please

avatar PhilETaylor
PhilETaylor - comment - 19 May 2017

PR #16137

avatar franz-wohlkoenig franz-wohlkoenig - change - 19 May 2017
Status New Closed
Closed_Date 0000-00-00 00:00:00 2017-05-19 18:45:45
Closed_By franz-wohlkoenig
avatar joomla-cms-bot joomla-cms-bot - change - 19 May 2017
The description was changed
Status Closed New
avatar joomla-cms-bot joomla-cms-bot - edited - 19 May 2017
avatar joomla-cms-bot joomla-cms-bot - change - 19 May 2017
Status New Closed
Closed_By franz-wohlkoenig joomla-cms-bot
avatar joomla-cms-bot joomla-cms-bot - close - 19 May 2017
avatar joomla-cms-bot
joomla-cms-bot - comment - 19 May 2017
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 19 May 2017

closed as having PR #16137


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16065.

avatar brianteeman
brianteeman - comment - 19 May 2017

@PhilETaylor thanks but it would have been nice if you had waited a little while to give them time to contribute

Add a Comment

Login with GitHub to post a comment