? Pending

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
17 May 2017

When using Multingual associations, the item types should be in plural form.
Contact was the only one singular.

Before patch
screen shot 2017-05-17 at 09 52 28

After patch
screen shot 2017-05-17 at 09 50 54

Simple change. Can be merged on review for 3.7.2

avatar infograf768 infograf768 - open - 17 May 2017
avatar infograf768 infograf768 - change - 17 May 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 17 May 2017
Category Administration Language & Strings
avatar infograf768 infograf768 - change - 17 May 2017
Title
[Associations} Contact item type should be plural
[Associations] Contact item type should be plural
avatar infograf768 infograf768 - edited - 17 May 2017
avatar brianteeman
brianteeman - comment - 17 May 2017

Fine by me - it looks like a bug as it is correct in the .sys.ini file and thats the file used for the dropdown menus

avatar infograf768
infograf768 - comment - 17 May 2017

Although both .ini and sys.ini do load, the string is picked from the .ini in multilingual associations (nothing to do with menus dropdown)
Same for all these types.

avatar brianteeman
brianteeman - comment - 17 May 2017

yes i was just pointing out that the menu dropdowns are all correctly plural

avatar brianteeman
brianteeman - comment - 17 May 2017

I have tested this item successfully on 2b339a2


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16063.

avatar brianteeman brianteeman - test_item - 17 May 2017 - Tested successfully
avatar infograf768
infograf768 - comment - 17 May 2017

BTW, I found why .ini superseeds sys.ini in multilingual associations.
In the helper, we have in the getSupportedExtension method

		// Get the translated titles.
		$languagePath = JPATH_ADMINISTRATOR . '/components/' . $extensionName;
		$lang         = JFactory::getLanguage();

		$lang->load($extensionName . '.sys', JPATH_ADMINISTRATOR);
		$lang->load($extensionName . '.sys', $languagePath);
		$lang->load($extensionName, JPATH_ADMINISTRATOR);
		$lang->load($extensionName, $languagePath);

		$result->def('title', JText::_(strtoupper($extensionName)));

and further

if ($lang->hasKey(strtoupper($extensionName . '_' . $title . 'S')))
			{
				$languageKey = strtoupper($extensionName . '_' . $title . 'S');
			}

Mystery solved. ;)

avatar brianteeman
brianteeman - comment - 17 May 2017

just wondering if that needs to be fixed as perhaps it will cause issues with non core extensions using associations?

avatar infograf768
infograf768 - comment - 17 May 2017

I think we must have had a reason for that.
One of the requirements for 3rd party extensions (among a lot of others) is to provide such string in the .ini, if not already present.

avatar alikon
alikon - comment - 17 May 2017

I have tested this item successfully on 2b339a2


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16063.

avatar alikon alikon - test_item - 17 May 2017 - Tested successfully
avatar infograf768 infograf768 - change - 17 May 2017
Milestone Added:
Status Pending Ready to Commit
avatar infograf768
infograf768 - comment - 17 May 2017

RTC. Thanks for testing.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16063.

avatar rdeutz rdeutz - change - 22 May 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-05-22 18:21:18
Closed_By rdeutz
Labels Added: ?
avatar rdeutz rdeutz - close - 22 May 2017
avatar rdeutz rdeutz - merge - 22 May 2017

Add a Comment

Login with GitHub to post a comment