[#16061] - Regression in mod_menu - base item type other than component not showing
- Closed
- 8 Aug 2021
- Medium
- Build: staging
- # 16061
- Diff
- Devportobello:modMenuBaseItemModalMenu
- Pending continuous-integration/drone/pr this build is pending Details
- Success hound No violations found. Woof! Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #15617 .
Summary of Changes
Added 1 parameter to XML modal_menu field to allow possibility to enable type of menu item
Testing Instructions
Create 1 menu eg: Main
Add to this menu some items like this:
Level - Item - Type
1 - Home - Article
2 - Activities - Menu heading
2.1 - Activity 1 - Article
2.2 - Activity 2 - Article
2.3 - Activity 3 - Article
3 - Contact - Article
Then go to modules > add a new module "Menu"
Select Menu : Main
Select base item : Activities
Expected result
Could select "Activites"
Actual result
Unable to see and select "Activities"
Final point
Maybe could better to use a disable parameter, if right, we need to modify all modal_menu to B/C
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_menus Modules Front End |
Yes working in 3.6.5;
UPDATED: prior of : 1f48268#diff-d5d92c503f1c0d0d4368cceb1e31ff4fR90
| Labels |
Added:
?
|
||
Just applied this to a test site. When opening the modal and applying a filter, the whole menu item list is empty. The form submit on the filter is removing the "enable" param. This also happens on the pagination.
Adding:
<input type="hidden" name="enable" value="<?php echo $app->input->get('enable', '', 'string'); ?>" />
Solves this
local and fork repo was in bad situation... how can i erase this last commits T_T
Any update on getting this in to Joomla release? It really annoying I can't set the base item for menus when they are aliases
To get this in, this PR has first to be updated to solve the conflicts.
and it has to have successful tests
and it has to have successful tests
right and at first sight I am not sure it is B/C as some other modal_menu fields do not have a disable attrib (some redirects where one could choose a Heading as redirect) or creating an alias menu item aliased to another alias menu item, etc.)
But we really can't test until updated.
This need serious test, too much case...
@Devportobello Are you still around? Can you fix the conflicts?
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-08-08 20:08:54 |
| Closed_By | ⇒ | zero-24 | |
| Labels |
Added:
?
Removed: ? |
||
Dear @Devportobello
in preperation of the upcomming release of Joomla 3.10 we have used GitHubs rename feature to rename the staging branch into 3.10-dev. Usually GitHub moves all existing PRs towards the new branch just fine, but here it didnt work. The reason seems to be that the fork of the CMS that was used as base for this PR has been deleted so GitHub does no longer have a base to rebase the PR against the new branch and we are also not able to reopen the PR. For that reason GitHub closed this PR in my name, when this issue is still valid It would require a new PR against the new 3.10-dev or 4.0-dev branch.
Was that working in 3.6.5?