[#16040] - Return valid HTTP 1.1 Status line
- Fixed in Code Base
- 5 Aug 2017
- Medium
- Build: staging
- # 16040
- Diff
- rdeutz:fix_16038
- Success continuous-integration/drone/pr the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #16038
Summary of Changes
Added more status to the responseMap and tried to get the best value for a code. Status should now a Valid HTTP 1.1 Status line as per https://www.w3.org/Protocols/rfc2616/rfc2616-sec6.html
Testing Instructions
Test different situations and check if the status is a valid status according to the document listet above.
Before Patch
Not valid status codes
After Patch
Valid status codes
Documentation Changes Required
None
Note: I had to change the unit test because they are testing wrong behaviour
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries Unit Tests |
| Labels |
Added:
?
?
|
||
@brianteeman done
The redirect function needs to now check if this is a 3xx status code (the original point of the $responseMap class variable` rather than just checking if it is a key of that variable)
Looks good to me :)
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-08-05 05:20:19 |
| Closed_By | ⇒ | rdeutz |
Can you order the status codes numerically please