[#16028] - [com_fields] Update default_custom.php
- Fixed in Code Base
- 8 Jun 2017
- Medium
- Build: staging
- # 16028
- Diff
- coolcat-creations:patch-1
User tests: Successful: Unsuccessful:
Change fields to jcfields like it has to be
Summary of Changes
Changed $this->data->fields to $this->data->jcfields, because otherwise the intended mapping of the fieldname wouldn´t work otherwise.
Testing Instructions
Create an override of default_custom.php
Add another Field at the bottom with
<?php echo $customFields['fieldname']->value; ?>
Where fieldname has to have the fieldname...
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_users |
| Labels |
Added:
?
|
||
@coolcat-creations I did not follow your testing instructions, however, it fixed the following. Is this PR related to this issue?
Before:
After:
@Quy I don´t know if that is fixed by my PR because normally the field would not be shown at all before. But i see the lable is shown there. Maybe just follow the instructions too and mark it as tested :) Would be great! It´s actually a logical change/bugfix because the name fields was changed to jc fields in the development process and this one was forgotten.
I have tested this item
In the revised file, I added a var_dump($tmp). Before the change, empty array. After the change, an array of the custom fields.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16028.
@franz-wohlkoenig Can this be RTC? It has 1 successful test and the developer of the custom fields has approved it.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16028.
Now you have your second test. But the branch needs to fix a merge conflict.
| Status | Pending | ⇒ | Ready to Commit |
RTC after two successful tests.
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-06-06 19:53:01 |
| Closed_By | ⇒ | rdeutz |
| Status | Closed | ⇒ | New |
| Closed_Date | 2017-06-06 19:53:01 | ⇒ | |
| Closed_By | rdeutz | ⇒ | |
| Labels |
Removed:
?
|
||
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
|
||
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-06-08 10:07:06 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Removed:
?
|
||
Can someone test this, actually this seemed to be just forgotten when changing alias to name and fields to jcfields...