[#16017] - Update phpversioncheck.php
- Fixed in Code Base
- 23 May 2017
- Medium
- Build: staging
- # 16017
- Diff
- StefanSTS:patch-1
User tests: Successful: Unsuccessful:
Pull Request for Issue #14571 .
Summary of Changes
Message for nearing eol appears three month before eol.
Testing Instructions
If you have PHP 5.6 the quickicon message should disappear. Changing the 3 month into e.g. 23 month, anything more than the real remaining time, should make the message appear again.
$interval = new DateInterval('P3M'); // line 179, message gone
$interval = new DateInterval('P23M'); // message appears
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
Could you guys help with the procedure how to go forward, please.
It needs 2 people (other than you) to test the behavioral changes and a maintainer to review the code change and decide if it should be merged. Instructions on how to test that for our lesser-technical folks would be beneficial.
@StefanSTS Test Instructions a non-Technical like: #15998
@StefanSTS "Quick Icon - PHP Version Check" is enabled, no Warning.
System information
3.7.3-dev
Multilanguage Site
macOS Sierra, 10.12.4
Firefox 53 (64-bit)
MAMP 4.1.1
- PHP 7.0.15
- MySQLi 5.6.35
@franz-wohlkoenig thats because you are on php 7!!! Please read the test instructions again
Choose PHP 5.6 for your Joomla site (in your hosting panel or your local server), if not chosen.
Did install the patch and I can confirm that it works as it should do. No php warning in case of php 5.6.30. Did switch to php 5.5.38 and I receive an error message, which is correct because not any more supported by developers. So everything works fine with that patch.
Tzz, reading "PHP" and thinking "MySQL".
@franzpeter please mark as tested https://issues.joomla.org/tracker/joomla-cms/16017 (after login the Test button appears). See https://docs.joomla.org/Testing_Joomla!_patches#Recording_test_results
@wojsmol have altered Test of @franzpeter
Tested sucessfully with php 5.6.28 according to test instructions.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16017.
| Status | Pending | ⇒ | Ready to Commit |
RTC after two successful tests.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16017.
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-05-23 19:38:15 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
?
|
||
Thanks all participants and testers for helping to get this done!
@Bakual @mbabker Could you guys help with the procedure how to go forward, please.
I didn't want to disturb at the time of the security release. But I hope you got a bit time for this now. I really think it will help as explained before in #14571.