? Pending

User tests: Successful: Unsuccessful:

avatar ciar4n
ciar4n
14 May 2017

Pull Request for Issue #16000 (part of).

Summary of Changes

Initial PR to apply #16000.

  • Creates a style class (tbody-icon) and applies it to the list status icons.
  • Moves the 'checked-in' icon to the status column.

Testing Instructions

Apply PR and navigate to table list containing 'status' icons.

Before PR

status-icons1

After PR

status-icons2

avatar ciar4n ciar4n - open - 14 May 2017
avatar ciar4n ciar4n - change - 14 May 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 14 May 2017
Category Administration com_content Templates (admin) Libraries
avatar brianteeman
brianteeman - comment - 14 May 2017

what would happen if it is featured and locked

avatar C-Lodder
C-Lodder - comment - 14 May 2017

@brianteeman the lock icon should appear next to the "featured" icon.

@ciar4n - might be an idea to remove the style="width:1%" from the status <th> so that it doesn't wrap.

avatar ciar4n
ciar4n - comment - 14 May 2017

Currently only the locked icon will appear (2nd item in the screenshot).

I could add a 3rd icon instead? Just means the status column would be wider and a little busy looking..

status-icons3

avatar brianteeman
brianteeman - comment - 14 May 2017

I think you see the issue that i raised now.
Having a third column just to show an icon that really should never be seen is not great but at the same time you need to have it as you cant show all three otherwise.

Might need to rethink the idea of moving the locked icon next to featured.

I would also raise a question that the lock icon is not the same as the others you are displaying it with. All the others are both an indicator and an action but locked is only an indcator

avatar ciar4n
ciar4n - comment - 14 May 2017

@C-Lodder There is a nowrap class on it so should be ok. Removing the style gives some varying widths depending on browser/table width

avatar ciar4n
ciar4n - comment - 14 May 2017

As you point out, having a 3rd icon column for a relatively rare usage doesn't make much sense. Moving back inline with the title might be the way to go.

avatar brianteeman
brianteeman - comment - 14 May 2017

@ciar4n unfortunately I think thats best for now

avatar ciar4n ciar4n - change - 14 May 2017
Labels Added: ?
avatar ciar4n
ciar4n - comment - 14 May 2017

Latest commit moves locked icon inline with title...

status-icons4

avatar dgt41
dgt41 - comment - 14 May 2017

@ciar4n here is another idea about the checkin icon:
If the row needs to be checked out (icon should appear) then the other icons shouldn't display
else you just display the publish/featured

avatar wilsonge
wilsonge - comment - 14 May 2017

PS From a workflow also this sounds the correct approach, e.g. if someone is editing this article, publishing or featuring that article doesn't sound a good idea...

But someone looking at the list should be able to see whether they are published/featured or not

avatar ciar4n
ciar4n - comment - 14 May 2017

@dgt41 So basically this?...

status-icons5

avatar brianteeman
brianteeman - comment - 14 May 2017

It would also fail on accessibility etc.

avatar dgt41
dgt41 - comment - 14 May 2017

But someone looking at the list should be able to see whether they are published/featured or not

The article is currently edited by another user, unless they finish their task (e.g. unpublish a published article) the information could be wrong, think about it...

avatar wilsonge
wilsonge - comment - 14 May 2017

They can't change the information, but they should to be able to see a 'read-only' published state at minimum

avatar dgt41
dgt41 - comment - 14 May 2017

but they should to be able to see a 'read-only' published state at minimum

But that info might be wrong if the person editing the article changes that state, so what's the point displaying some previous, inaccurate state?

avatar dgt41
dgt41 - comment - 14 May 2017

It would also fail on accessibility etc.

@brianteeman why?

avatar brianteeman
brianteeman - comment - 14 May 2017

@dgt41 by that argument everything displayed on the row might be wrong

avatar dgt41
dgt41 - comment - 14 May 2017

by that argument everything displayed on the row might be wrong

Good point! everything except the ID

avatar C-Lodder
C-Lodder - comment - 14 May 2017

@ciar4n nowrap is for J3. The class hasn't been mapped. :)

avatar ciar4n
ciar4n - comment - 14 May 2017

@C-Lodder Ah I see what you mean. We do have the following so I guess them nowraps can be removed... https://github.com/joomla/joomla-cms/blob/4.0-dev/administrator/templates/atum/scss/vendor/bootstrap/_table.scss#L6

avatar C-Lodder
C-Lodder - comment - 14 May 2017

It's on my to-do list

avatar brianteeman
brianteeman - comment - 15 May 2017

I just noticed that one of the aims of this PR is to remove the matching toolbar buttons in favour of the action list. I dont think thats a great idea as currently that would mean there was no way to do a mass action eg unpublish all the articles

avatar ciar4n
ciar4n - comment - 15 May 2017

This particular PR is just for the icon styling. Regarding #16000 the action list will apply to the selected items...

status-icons6

avatar brianteeman
brianteeman - comment - 15 May 2017

ah - ok - missed that part - cool

avatar C-Lodder
C-Lodder - comment - 15 May 2017

Everything working fine for me. Just needs applying to the rest of the components

avatar joomla-cms-bot joomla-cms-bot - change - 15 May 2017
Category Administration com_content Templates (admin) Libraries Administration com_contact com_content Templates (admin) Libraries
avatar ciar4n
ciar4n - comment - 15 May 2017

Thanks Charlie.. Done

avatar C-Lodder
C-Lodder - comment - 15 May 2017

I have tested this item successfully on 04bd98e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16015.

avatar C-Lodder C-Lodder - test_item - 15 May 2017 - Tested successfully
avatar wilsonge
wilsonge - comment - 15 May 2017

Needs something in the redirect component too :)

avatar joomla-cms-bot joomla-cms-bot - change - 15 May 2017
Category Administration com_content Templates (admin) Libraries com_contact Administration com_contact com_content com_redirect Templates (admin) Libraries
avatar ciar4n
ciar4n - comment - 15 May 2017

@wilsonge Good catch.. Done

avatar wilsonge wilsonge - change - 15 May 2017
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-05-15 14:28:42
Closed_By wilsonge
avatar wilsonge wilsonge - close - 15 May 2017
avatar wilsonge wilsonge - merge - 15 May 2017

Add a Comment

Login with GitHub to post a comment