User tests: Successful: Unsuccessful:
Pull Request for Issue #16000 (part of).
Initial PR to apply #16000.
tbody-icon
) and applies it to the list status icons.Apply PR and navigate to table list containing 'status' icons.
Status | New | ⇒ | Pending |
Category | ⇒ | Administration com_content Templates (admin) Libraries |
@brianteeman the lock icon should appear next to the "featured" icon.
@ciar4n - might be an idea to remove the style="width:1%"
from the status <th>
so that it doesn't wrap.
I think you see the issue that i raised now.
Having a third column just to show an icon that really should never be seen is not great but at the same time you need to have it as you cant show all three otherwise.
Might need to rethink the idea of moving the locked icon next to featured.
I would also raise a question that the lock icon is not the same as the others you are displaying it with. All the others are both an indicator and an action but locked is only an indcator
As you point out, having a 3rd icon column for a relatively rare usage doesn't make much sense. Moving back inline with the title might be the way to go.
Labels |
Added:
?
|
PS From a workflow also this sounds the correct approach, e.g. if someone is editing this article, publishing or featuring that article doesn't sound a good idea...
But someone looking at the list should be able to see whether they are published/featured or not
It would also fail on accessibility etc.
But someone looking at the list should be able to see whether they are published/featured or not
The article is currently edited by another user, unless they finish their task (e.g. unpublish a published article) the information could be wrong, think about it...
They can't change the information, but they should to be able to see a 'read-only' published state at minimum
but they should to be able to see a 'read-only' published state at minimum
But that info might be wrong if the person editing the article changes that state, so what's the point displaying some previous, inaccurate state?
It would also fail on accessibility etc.
@brianteeman why?
by that argument everything displayed on the row might be wrong
Good point! everything except the ID
@C-Lodder Ah I see what you mean. We do have the following so I guess them nowrap
s can be removed... https://github.com/joomla/joomla-cms/blob/4.0-dev/administrator/templates/atum/scss/vendor/bootstrap/_table.scss#L6
It's on my to-do list
I just noticed that one of the aims of this PR is to remove the matching toolbar buttons in favour of the action list. I dont think thats a great idea as currently that would mean there was no way to do a mass action eg unpublish all the articles
ah - ok - missed that part - cool
Everything working fine for me. Just needs applying to the rest of the components
Category | Administration com_content Templates (admin) Libraries | ⇒ | Administration com_contact com_content Templates (admin) Libraries |
Thanks Charlie.. Done
I have tested this item
Needs something in the redirect component too :)
Category | Administration com_content Templates (admin) Libraries com_contact | ⇒ | Administration com_contact com_content com_redirect Templates (admin) Libraries |
Status | Pending | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-05-15 14:28:42 |
Closed_By | ⇒ | wilsonge |
what would happen if it is featured and locked