? Pending

User tests: Successful: Unsuccessful:

avatar joomdonation
joomdonation
14 May 2017

Pull Request for Issue # .

Summary of Changes

This simple PR converts com_templates component to namespace MVC for Joomla 4.

Testing Instructions

  1. Install latest Joomla 4.0-dev with sample data, then apply patch (or better install my branch https://github.com/joomdonation/joomla-cms/archive/namespace_com_templates.zip )

  2. Access to backend, access to Extensions -> Templates, test the manage Templates and Styles, make sure it is working as before

Notes

By looking at the code, look like there is a function to compile less files. However, the library classes like JLess is not available anymore, If I remember correctly, the classes were removed. So I guess we should remove that option from template manage ?

avatar joomdonation joomdonation - open - 14 May 2017
avatar joomdonation joomdonation - change - 14 May 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 14 May 2017
Category Administration com_templates
07b86b9 14 May 2017 avatar joomdonation CS
avatar joomdonation joomdonation - change - 14 May 2017
Labels Added: ?
avatar wilsonge
wilsonge - comment - 14 May 2017

Yes we should remove the compile less button :)

avatar joomdonation
joomdonation - comment - 14 May 2017

OK. I removed the button + the code which handles less compile. Should be good now. I don't know why drop is failed but it is not related with the last changes

avatar wilsonge wilsonge - change - 14 May 2017
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-05-14 14:57:57
Closed_By wilsonge
avatar wilsonge wilsonge - close - 14 May 2017
avatar wilsonge wilsonge - merge - 14 May 2017
avatar wilsonge
wilsonge - comment - 14 May 2017

Some sort of javascript test fail. I'll get @dgt41 on it ;)

Add a Comment

Login with GitHub to post a comment