Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#16007] - Mark file as deprecated

? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
14 May 2017

This form has not been used since Joomla 1.6. Marking it as deprecated so that it can be removed in j4

avatar brianteeman brianteeman - open - 14 May 2017
avatar brianteeman brianteeman - change - 14 May 2017
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 14 May 2017
Category ⇒ Front End com_contact
avatar PhilETaylor
PhilETaylor - comment - 15 May 2017

Just delete the file. If its not been used since Joomla 1.6, we dont promise b/c to 1.6 :)

avatar brianteeman
brianteeman - comment - 15 May 2017

we dont know if a third party is using it so it needs to be deprecated correctly

avatar tonypartridge tonypartridge - test_item - 23 May 2017 - Tested successfully
avatar tonypartridge
tonypartridge - comment - 23 May 2017

@brianteeman can you move the deprecation notice to line 2?

avatar brianteeman brianteeman - change - 23 May 2017
Labels Added: ?
avatar tonypartridge
tonypartridge - comment - 23 May 2017

I have tested this item ✅ successfully on c3c8a89

Tested replacing the getForm method to use form file, to confirm.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16007.

avatar tonypartridge tonypartridge - test_item - 23 May 2017 - Tested successfully
avatar brianteeman
brianteeman - comment - 25 May 2017

As this has now been removed from J4 please can this simple PR to add a deprecation notice be merged

avatar wilsonge wilsonge - change - 25 May 2017
Status Pending ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2017-05-25 22:36:22
Closed_By ⇒ wilsonge
avatar wilsonge wilsonge - close - 25 May 2017
avatar wilsonge wilsonge - merge - 25 May 2017
avatar brianteeman
brianteeman - comment - 25 May 2017

Thanks

Add a Comment

Login with GitHub to post a comment