? Pending

User tests: Successful: Unsuccessful:

avatar joomdonation
joomdonation
13 May 2017

Pull Request for Issue # .

Summary of Changes

This simple PR converts com_search component to namespace MVC for Joomla 4.

Testing Instructions

  1. Install latest Joomla 4.0-dev with sample data, then apply patch (or better install my branch https://github.com/joomdonation/joomla-cms/archive/namespace_com_search.zip )

  2. Login to administrator area, access to Components -> Search, click on Options button in the toobar, set Gather Search Statistics parameter to Yes

  3. Access to frontend of the site, try to search for something using search module, make sure the search result is displayed.

  4. Access to administrator area, access to Components -> Search again, make sure the search phrases which you searched before is displayed.

Additional comment

Right now, we still have to use \JLoader::register('SearchHelper', JPATH_ADMINISTRATOR . '/components/com_search/helpers/search.php'); in Controller display method because plugins are using SearchHelper class without registering for it. Later, we can modify the search plugin to use namespace helper class directly and if it is allowed , we can remove the SearchHelper class in later phase

avatar joomdonation joomdonation - open - 13 May 2017
avatar joomdonation joomdonation - change - 13 May 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 13 May 2017
Category Administration com_search Front End
avatar wilsonge wilsonge - change - 13 May 2017
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-05-13 17:06:24
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 13 May 2017
avatar wilsonge wilsonge - merge - 13 May 2017

Add a Comment

Login with GitHub to post a comment