[#15976] - 0 - Using $this when not in object context when using &JSite::getMenu();
- Closed
- 12 May 2017
- Medium
- Build: staging
- # 15976
Steps to reproduce the issue
- My site works fine on PHP 7.0.14
- After switch on PHP 7.1 site down with error '0 - Using $this when not in object context'
- Looking to Call stack I see:
1 JApplicationCms::getMenu() JROOT\libraries\cms\application\site.php:272
2 JApplicationSite::getMenu() JROOT\modules\mod_my_cloud\mod_my_cloud.php:69
- mod_my_cloud.php:69 is: $menus = &JSite::getMenu();
- After commenting line 69 in mod_my_cloud.php works ok
Expected result
Actual result
System information (as much as possible)
System Information
PHP Built On Windows NT C45779 6.1 build 7601 (Windows 7 Enterprise Edition Service Pack 1) AMD64
Database Version 5.5.22
Database Collation utf8_general_ci
Database Connection Collation utf8mb4_general_ci
PHP Version 7.1.5
Web Server Apache/2.4.23 (Win64) OpenSSL/1.0.2h PHP/7.1.5
WebServer to PHP Interface apache2handler
Joomla! Version Joomla! 3.7.0 Stable [ Amani ] 25-April-2017 15:36 GMT
Joomla! Platform Version Joomla Platform 13.1.0 Stable [ Curiosity ] 24-Apr-2013 00:00 GMT
User Agent Mozilla/5.0 (Windows NT 6.1; WOW64; rv:42.0) Gecko/20100101 Firefox/42.0
Additional comments
| Labels |
Added:
?
|
||
| Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-05-12 05:37:00 |
| Closed_By | ⇒ | franz-wohlkoenig |
| Closed_By | franz-wohlkoenig | ⇒ | joomla-cms-bot |
Set to "closed" on behalf of @franz-wohlkoenig by The JTracker Application at issues.joomla.org/joomla-cms/15976
Its not only about non-Core-Module. Its about error in JApplicationCms::getMenu() JROOT\libraries\cms\application\site.php:272 when using &JSite::getMenu() in PHP 7.1
| Status | Closed | ⇒ | Discussion |
| Closed_Date | 2017-05-12 05:37:00 | ⇒ | |
| Closed_By | joomla-cms-bot | ⇒ |
| Status | Discussion | ⇒ | New |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ |
Set to "open" on behalf of @franz-wohlkoenig by The JTracker Application at issues.joomla.org/joomla-cms/15976
| Category | ⇒ | Libraries |
@mokhin-denis thanks, reopened.
$menus = &JSite::getMenu();
That code is plain wrong, that is the issue. I'm surprised this even worked before. JSiteis just a useless helper class from com_search.
To fetch the active menu, you do JFactory::getApplication()->getMenu()
Closing as non-core issue. The issue is using wrong code in that module.
| Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-05-12 06:17:53 |
| Closed_By | ⇒ | Bakual |
looks like Issue with non-Core-Module (mod_my_cloud), so closing. If i'm wrong, please feel free to reopen.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15976.