? Pending

User tests: Successful: Unsuccessful:

avatar matrikular
matrikular
11 May 2017

Summary of Changes

Prevent html markup from being rendered to the email when an empty (optional) field value has been submitted.

Testing Instructions

Prerequisites

The installation you test this in should be able to send an actual email.

  • Create a contact item (link to a user or fill in a valid email address)
  • Create a menu item linking to that contact
  • Create a custom text field in the mail context (filter). Just give it a name e.g. foobar or test
  • Save the field (it doesn't have to be in a group)
  • In the permissions tab of that very field, change "Edit Custom Field Value" from Inherited to Allowed

If everything worked fine, visiting that previously created contact in the frontend should show you the default contact form + the test field.

  • Fill in every field but the test field (should be marked "optional") and submit the form.

Expected result

The expected result would be an email including the fields submitted by the form, including the label followed by a colon (e.g. Test:)

Actual result

The mail send includes the following HTML markup instead of the label of our custom field.

<dl class="fields-container">
	</dl>

Apply the patch and test again. The markup should be replaced by the label and / or the value, depending on the fields settings.

avatar matrikular matrikular - open - 11 May 2017
avatar matrikular matrikular - change - 11 May 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 11 May 2017
Category Front End com_contact
avatar chmst
chmst - comment - 11 May 2017

I have tested this item successfully on 7a21916

Nice find :) I've tested this successfully and it works fine for me.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15968.

avatar chmst chmst - test_item - 11 May 2017 - Tested successfully
avatar laoneo
laoneo - comment - 11 May 2017

I have tested this item successfully on 7a21916


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15968.

avatar laoneo laoneo - test_item - 11 May 2017 - Tested successfully
avatar franz-wohlkoenig franz-wohlkoenig - change - 11 May 2017
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 11 May 2017

RTC after two successful tests.

avatar rdeutz rdeutz - change - 22 May 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-05-22 18:30:36
Closed_By rdeutz
Labels Added: ?
avatar rdeutz rdeutz - close - 22 May 2017
avatar rdeutz rdeutz - merge - 22 May 2017

Add a Comment

Login with GitHub to post a comment