? Pending

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
11 May 2017

Pull Request for Issue #15856

Testing Instructions

Create a contact for a user who is the author of some articles, make sure to set different Publishing dates for these articles and archive one of them.
Display the contact for that user in frontend. Make sure Articles are set to display.

Actual result

When displaying a contact's articles, they are displayed by Archived descendant first and then by Created date descendant.

We have
->order('a.state DESC, a.created DESC');
and
$query->where('a.state IN (1,2)') (2 is for the Archived)

This makes no sense (or should be the choice of the user, see further)

Expected result

After patching, they will be displayed by publishing date descendant.
Archives are also displayed in that order, therefore would be mixed among other articles.
This solves #15856

@AlexRed

Note: this patch could be largely improved

We may create new params to choose the way these articles are displayed:
Recently Created, Recently Published, Recently Modified (as in mod_articles_latest), and include or not Archives and Archives first/last.

I can modify this PR to include these new params. If we do, as langs are frozen for 3.7.1, it would be for a future version.

Please test patch and feedback wanted! 😄

avatar infograf768 infograf768 - open - 11 May 2017
avatar infograf768 infograf768 - change - 11 May 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 11 May 2017
Category Front End com_contact
avatar AlexRed
AlexRed - comment - 11 May 2017

I have tested this item ✅ successfully on 24ab819

Patch ok for me. Thanks


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15962.

avatar AlexRed AlexRed - test_item - 11 May 2017 - Tested successfully
avatar AlexRed
AlexRed - comment - 11 May 2017

Also showing the date of publication would be great :)
and also can select the categories for the articles.

Now in Joomla with the custom field we can finally have a personal page for the user. And the user can edit its info from the profile (only in frontend). I think it is interesting to expand this characteristic adding the parameters indicated by JM

avatar frostmakk
frostmakk - comment - 11 May 2017

I have tested this item ✅ successfully on 24ab819


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15962.

avatar frostmakk frostmakk - test_item - 11 May 2017 - Tested successfully
avatar franz-wohlkoenig franz-wohlkoenig - change - 12 May 2017
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 12 May 2017

RTC after two successful tests.

avatar rdeutz rdeutz - change - 22 May 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-05-22 18:32:27
Closed_By rdeutz
Labels Added: ?
avatar rdeutz rdeutz - close - 22 May 2017
avatar rdeutz rdeutz - merge - 22 May 2017

Add a Comment

Login with GitHub to post a comment