[#15946] - [4.0] Revert switcher
- Closed
- 11 Jul 2017
- Medium
- Build: 4.0-dev
- # 15946
- Diff
- Bakual:RevertSwitcher
- Success continuous-integration/drone/pr the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #15391 .
Summary of Changes
- Changes the order of the options back to what we have in J3, meaning Yes/Show on left side and No/Hide on the right.
- Removes the "Switcher" layout and JS and restores the btn-group behavior we have in J3.
Testing Instructions
Open various settings page. Most occurances of those radio elements are typical in component settings.
Expected result
Have an intuitive toggle button
Actual result
Have an unintuitive switcher thing with inverted option order and unclear states
Documentation Changes Required
None
Known issue
Maybe someone can help me here:
The btn-group doesn't work with the <fieldset> tag. I changed the tag generated in the radio JLayout to <div> and it works fine. This may be a bug in BS4, I wasn't able to figure out where the difference comes from.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_banners com_config com_contact com_content com_fields com_finder com_installer com_media com_menus com_messages com_modules com_newsfeeds com_redirect |
| Title |
|
||||||
| Title |
|
||||||
| Labels |
Added:
?
|
||||||
you need to remove switcher from grunt-settings.yaml and remove the related lines from Gruntfile.js.
@dgt41 Afaik it wasn't a file pulled in using Grunt, it something done ourself. I did have a look now at those grunt files and couldn't find anything related to switcher.js. If I missed something, feel free to point me to it.
Anyways I'm not in favour of removing the switcher but I'm ok with reverting the xml changes. By the way switcher can still be done with the original xml structure...
I did the changes to the XML, JS and CSS in separate commits for that reason so it would be easy to take only parts of this PR.
I think the switcher needs some serious work anyway if you want to use that. It lacks in many aspects currently. It may have situational use cases, but for regular options in components settings or menu params and the like I don't see us using it. It doesn't even look nice between selects and other inputs. The style and width just don't match.
My 2c i am not convinced that a switcher is suitable for a desktop application - so at this time I would agree to removing it and reverting back as here. It can be looked at again in the future
So this decision was actually driven based on us having some conflicts between CSS frameworks, but we ended up pulling out all of the switcher based checkboxes in the frontend of an app we're building right now in favor of "plain" checkboxes. I realize our switchers are primarily radio based, but the same general concept applies.
Got the btn-group-yesno working now. Still need to figure out the fieldsetvs div thing. I'm still lost there
| Milestone |
Added: |
||
| Milestone |
Added: |
||
At this time I am closing this PR. We need to let the J4 guys deliver and alpha with this and then we can of course review it then when a wider audience have seen it.
Change is always disturbing but we have to be brave and try things.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-07-11 23:35:28 |
| Closed_By | ⇒ | brianteeman |
@Bakual you need to remove switcher from grunt-settings.yaml and remove the related lines from Gruntfile.js.
Just rename the?
<div>to<joomla-buttons>and use the related custom elementAnyways I'm not in favour of removing the switcher but I'm ok with reverting the xml changes. By the way switcher can still be done with the original xml structure...