? Pending

User tests: Successful: Unsuccessful:

avatar C-Lodder
C-Lodder
10 May 2017

Pull Request for Issue #15774

Summary of Changes

Just some general styling updates and improvements for com_tags

all-tags

avatar C-Lodder C-Lodder - open - 10 May 2017
avatar C-Lodder C-Lodder - change - 10 May 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 10 May 2017
Category com_tags Front End
avatar brianteeman
brianteeman - comment - 10 May 2017

The escaping/validation of the image and alt are different in each case

avatar C-Lodder C-Lodder - change - 10 May 2017
Labels Added: ?
avatar C-Lodder
C-Lodder - comment - 10 May 2017

@brianteeman - removed the / from one of the other images, but not sure what you're referring to with the "escaping/validation"

avatar brianteeman
brianteeman - comment - 10 May 2017

<img src="<?php echo htmlspecialchars($images->image_fulltext, ENT_COMPAT, 'UTF-8'); ?>" alt="<?php echo htmlspecialchars($images->image_fulltext_alt); ?>">
<img src="<?php echo htmlspecialchars($images->image_intro); ?>" alt="<?php echo htmlspecialchars($images->image_intro_alt); ?>">
src="<?php echo $images->image_intro; ?>" alt="<?php echo htmlspecialchars($images->image_intro_alt); ?>">

avatar C-Lodder
C-Lodder - comment - 12 May 2017

@wilsonge can be merged

avatar wilsonge wilsonge - change - 12 May 2017
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-05-12 16:29:28
Closed_By wilsonge
avatar wilsonge wilsonge - close - 12 May 2017
avatar wilsonge wilsonge - merge - 12 May 2017

Add a Comment

Login with GitHub to post a comment