? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
10 May 2017

codestyle review for the xml files in the plugins folder

avatar brianteeman brianteeman - open - 10 May 2017
avatar brianteeman brianteeman - change - 10 May 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 10 May 2017
Category Front End Plugins
avatar wojsmol
wojsmol - comment - 10 May 2017

I'll review later.
cc @andrepereiradasilva Plase review.

avatar brianteeman brianteeman - change - 12 May 2017
Labels Added: ?
avatar brianteeman
brianteeman - comment - 25 May 2017

@Quy did that fix

avatar brianteeman
brianteeman - comment - 25 May 2017

conflicts resolved

c14156a 25 May 2017 avatar brianteeman grrg
avatar brianteeman
brianteeman - comment - 25 May 2017

@zero-24 fixed that

avatar Quy
Quy - comment - 25 May 2017

In profile.xml, add a line before lines 274 and 295.

avatar brianteeman
brianteeman - comment - 25 May 2017

@Quy done

avatar Quy
Quy - comment - 25 May 2017

I have tested this item successfully on f07e240

Code review.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15932.

avatar Quy Quy - test_item - 25 May 2017 - Tested successfully
avatar brianteeman
brianteeman - comment - 27 May 2017

Updated branch to restart travis - no need for new tests

avatar andrepereiradasilva
andrepereiradasilva - comment - 30 May 2017

I have tested this item successfully on ddcaf07

ok on code review.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15932.

avatar andrepereiradasilva andrepereiradasilva - test_item - 30 May 2017 - Tested successfully
avatar brianteeman
brianteeman - comment - 30 May 2017

RTC please?

avatar franz-wohlkoenig franz-wohlkoenig - change - 30 May 2017
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 30 May 2017

RTC

avatar brianteeman
brianteeman - comment - 1 Jun 2017

@wilsonge you will probably want to merge this and #15922 before you do your 3.8->4 merge

avatar Quy
Quy - comment - 1 Jun 2017

@brianteeman The following have blank lines to delete. I attempted to submit patches but they contain previous commits. Can you remove them or tell me how to do via Github interface? Thanks.

plugins/authentication/cookie/cookie.xml
plugins/authentication/ldap/ldap.xml
plugins/content/emailcloak/emailcloak.xml
plugins/editors/tinymce/tinymce.xml
plugins/fields/textarea/params/textarea.xml
plugins/fields/textarea/textarea.xml

avatar zero-24
zero-24 - comment - 1 Jun 2017

@Quy do you have Glip? If yes please contace me and i can help you with github. If you do not have a account please send me a mail to tobias.zulauf[at]community.joomla.org

avatar brianteeman brianteeman - change - 2 Jun 2017
Labels Added: ?
avatar wilsonge wilsonge - change - 4 Jun 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-06-04 10:40:18
Closed_By wilsonge
avatar wilsonge wilsonge - close - 4 Jun 2017
avatar wilsonge wilsonge - merge - 4 Jun 2017
avatar brianteeman
brianteeman - comment - 4 Jun 2017

Thanks

Add a Comment

Login with GitHub to post a comment