?
avatar aheinze
aheinze
26 Jul 2013

This breaks custom template code from 3rd party developers (theme settings).
Chosen is already applied on all selects with the class '.fancySelect' ... so there is no need to run it twice and on all select elements

Code to revert:

7eff170#administrator/components/com_templates/views/style/tmpl/edit_options.php

avatar aheinze aheinze - open - 26 Jul 2013
avatar mustaqsheikh
mustaqsheikh - comment - 26 Jul 2013

I agree. Commit #7eff170e should be reverted

avatar AmyStephen
AmyStephen - comment - 26 Jul 2013

Hi @aheinze and @mustaqsheikh -

As an FYI - it appears that this change was made a month ago for Beez and the Administrator http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=31168

Sounds like it would not be possible to remove it -- unless you have another solution for the core issues. Maybe propose a patch that takes care of both? Or, perhaps you no longer need to run that JHtml command? (Not sure, just sharing info.)

avatar aheinze
aheinze - comment - 26 Jul 2013

the right solution should be to add the fancySelect class to the select elements in Beez etc. this is the default way to go like in any other component. to apply chosen on all select elements by default without an option to to disable it on certain elements e.g. choosing another selector "select:not(.not-chosen)" instead of just plain "select" is not right and breaks code!

avatar AmyStephen
AmyStephen - comment - 26 Jul 2013

@aheinze Artur - can you work up a patch for that? That'll be the fastest path forward. Sounds like a quick releases is in the works so, the sooner, the better.

avatar Bakual
Bakual - comment - 29 Jul 2013

Just a note: JHtml::_('formbehavior.chosen') defaults to the class ".advancedSelect" if no selector is given. So imho it should make sense to use that class more instead of ".fancySelect".

There is also another issue brought up on the JBS discussion group when facing huge (10k+) amount of options. Then chosen will hang the browser.
I did an approach to fix that one here: https://github.com/Bakual/joomla-cms/compare/ListChosen, but didn't have the time yet to finish it.

Would be great if we can combine our forces somehow to get a solution which works for all. I certainly agree that chosen should not be applied to all selects. Imho the default class ".advancedSelect" should be used instead.

avatar brianteeman
brianteeman - comment - 13 Oct 2013

See #1609

avatar brianteeman brianteeman - close - 13 Oct 2013
avatar zero-24 zero-24 - close - 13 Oct 2013
avatar zero-24 zero-24 - change - 7 Jul 2015
Labels Added: ?
Removed: ? ?
Build staging

Add a Comment

Login with GitHub to post a comment