Feeling Lucky
?
[#15900] - Move JDate to namespace
- Fixed in Code Base
- 25 May 2017
- Medium
- Build: 3.8-dev
- # 15900
- Diff
- Digital-Peak:j3/namesapce/date
User tests: Successful: Unsuccessful:
Move JDate to namespace. I had to change the order of the include files, because JError::setErrorHandling adds a log entry where the date class is needed.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Libraries |
mbabker
- comment
- 8 May 2017
No there's no need but in theory you're fighting B/C arguments if you make it a plain \DateTime object by default (the formatted text logger uses the toISO8601 method on our class which isn't in the parent).
laoneo
- comment
- 9 May 2017
You mean like https://github.com/joomla/joomla-cms/blob/staging/libraries/joomla/log/logger/formattedtext.php#L131. Looks like a JDate is expected.
| Labels |
Added:
?
|
||
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-05-25 10:24:18 |
| Closed_By | ⇒ | wilsonge |
Is there a reason JLog needs to use a JDate object rather than a native DateTime (unsure given something has to change whether that's a better one than changing the loader order)
Just because the biggest reason for JDate is the ability to localise in the user's timezone. but clearly for logging that's not an issue.