? ? Pending

User tests: Successful: Unsuccessful:

avatar laoneo
laoneo
8 May 2017

Summary of Changes

This PR is a first step to namespace JForm and fields and rules. It moves JForm/JFormField/JFormHelper/JFormRule to the namespace Joomla\CMS\Form.

New attributes addfieldprefix, addformprefix, addruleprefix are introduced. They are addfieldpath, addformpath, addrulepath and do allow to add a global namespace prefixes. For example in the article.xml file the categoryedit form field is registered like:

<?xml version="1.0" encoding="utf-8"?>
<form>
	<fieldset addfieldprefix="Joomla\Component\Categories\Administrator\Field" >

The fields in the components com_content and com_categories are moved to namespace as well to illustrate including fields of other components and modal ones.

This pr is dona against the 4.0-dev branch. When i got merged, then I will port it back to J3. I needed some real use cases to see if I'm on the right track.

Testing Instructions

  • Create an article
  • Create a "Single Article" menu item with the new article

Expected result

Article can be created as the category is a required field and uses the categoryedit form field of com_categories.
The article modal field should open a modal window to select an article.

Actual result

All is working fine.

Documentation Changes Required

The new attributes do need to be documented.

avatar laoneo laoneo - open - 8 May 2017
avatar laoneo laoneo - change - 8 May 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 8 May 2017
Category Administration com_categories com_content Front End Libraries
67cf878 8 May 2017 avatar laoneo CS
avatar laoneo laoneo - change - 8 May 2017
Labels Added: ?
avatar laoneo laoneo - change - 8 May 2017
The description was changed
avatar laoneo laoneo - edited - 8 May 2017
avatar joomla-cms-bot joomla-cms-bot - change - 8 May 2017
Category Administration com_categories com_content Front End Libraries Administration com_categories com_content Front End Libraries Unit Tests
avatar franz-wohlkoenig franz-wohlkoenig - change - 8 May 2017
Title
Namespace JForm and some base classes
[4.0] Namespace JForm and some base classes
avatar joomla-cms-bot joomla-cms-bot - edited - 8 May 2017
avatar laoneo laoneo - change - 15 May 2017
Labels Added: ?
avatar laoneo laoneo - change - 30 May 2017
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2017-05-30 15:59:25
Closed_By laoneo
avatar laoneo laoneo - close - 30 May 2017
avatar laoneo laoneo - change - 30 May 2017
Status Closed New
Closed_Date 2017-05-30 15:59:25
Closed_By laoneo
avatar laoneo laoneo - change - 30 May 2017
Status New Pending
avatar laoneo laoneo - reopen - 30 May 2017
avatar wilsonge
wilsonge - comment - 31 May 2017

After our conversation last night please un-namespace the text form field, fix conflicts and this is good to merge

avatar wilsonge wilsonge - change - 31 May 2017
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-05-31 13:09:14
Closed_By wilsonge
avatar wilsonge wilsonge - close - 31 May 2017
avatar wilsonge wilsonge - merge - 31 May 2017
avatar wilsonge
wilsonge - comment - 31 May 2017

Nice stuff :)

Add a Comment

Login with GitHub to post a comment