? Pending

User tests: Successful: Unsuccessful:

avatar Bakual
Bakual
8 May 2017

PR #3447 introduced a new class JInstallerScript which allows to specify a minimum PHP and Joomla version for extensions by simply setting the respective property in the extensions script file (assuming it extends that class).
The check is done during the preflight stage.

Summary of Changes

  • Changing those checks so they actually return false if the minimum requirement fails, aborting the installation with an error message. Currently it just shows the warning but the extensions still installs.
  • Changing the version check so it is indeed a minimum requirement. Currently the specified minimum version is considered "to low".

Testing Instructions

If you have an extension already using those features, test that it works as expected. Adjust the minimum versions and check that installation succeeds/fails as expected.

Expected result

If the installation doesn't meet the minimum requirements, the extension should not install.
If the installation meets exactly the minimum requirements, the extension should install without any message.

Actual result

Installation isn't aborted at all and if the minimum requirement is met exactly, the message is still shown.

Documentation Changes Required

None

Pinging @wilsonge since he was the original writer of those lines.

avatar Bakual Bakual - open - 8 May 2017
avatar Bakual Bakual - change - 8 May 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 8 May 2017
Category Libraries
avatar Bakual Bakual - change - 8 May 2017
Title
Stop installation if minimum requirement isn't met.
Stop extension installation if minimum requirement isn't met.
avatar Bakual Bakual - edited - 8 May 2017
avatar rdeutz rdeutz - change - 27 May 2017
Labels Added: ?
avatar brianteeman
brianteeman - comment - 29 May 2017

@Bakual if you can provide an extension to use for testing it will get tested faster :)

avatar Bakual
Bakual - comment - 29 May 2017

Sure thing. I've adjusted my component so it requires Joomla 3.7.3 and PHP 7.1.0 as minimum.
Without this PR you will get a message that it doesn't meet the minimum requirements but it still installs. With the PR applied the installation will be aborted and you get the message that either the PHP version (if you're under PHP 7.1.0) or the Joomla version doesn't meet the requirements.
com_sermonspeaker.zip

avatar brianteeman
brianteeman - comment - 29 May 2017

I have tested this item successfully on 864de80


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15890.

avatar brianteeman brianteeman - test_item - 29 May 2017 - Tested successfully
avatar Quy
Quy - comment - 29 May 2017

I have tested this item successfully on 864de80


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15890.

avatar Quy Quy - test_item - 29 May 2017 - Tested successfully
avatar brianteeman
brianteeman - comment - 29 May 2017

@Bakual see how quick that was :)

avatar wilsonge wilsonge - change - 29 May 2017
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-05-29 22:36:57
Closed_By wilsonge
avatar wilsonge wilsonge - close - 29 May 2017
avatar wilsonge wilsonge - merge - 29 May 2017

Add a Comment

Login with GitHub to post a comment