[#15873] - Allow check in from item in associations view
- Fixed in Code Base
- 10 May 2017
- Medium
- Build: staging
- # 15873
- Diff
- rdeutz:fix_13999
User tests: Successful: Unsuccessful:
Pull Request for Issue #13999.
Summary of Changes
Added a function to checkin item from the associations view.
Testing Instructions
- Go to Components > Multilingual Association
- Filter by articles and english language (it can be another component and/or language)
- Open a Multilingual Association from the results
- Don't click close button, just open a new tab and go to Components > Multilingual Association, so the association will we locked and you will see the lock icon
Before Patch
If you click on check-in icon, nothing happens.
After Patch
The item is checked in.
Please also test with other items as articles
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_associations Language & Strings |
check-in if I do not mistake (it is at least the way it is displayed in the toolbar)
we have a style guide - please us it
| Labels |
Added:
?
?
|
||
fixing a bug 1 hour; making the comments right several hours ;-)
I do not want to be the bad boy here but I confirm we use check-in 44 times in en-GB lang files...
so it is wrong 44 time :-P
or maybe it is being used according to the style guide 44 times.
My test:
- This works fine when an item displayed in the list has been checked out by the same user who is using multilingual associations. In that sense it solves #13999
If the item is marked as checked-out, one can check it in and then click to open the side by side.
- Now, when another user (with no check in ability) is with another browser displaying an item which has been checkedout, we do not get the grey lock but only an absence of link:
Example:
We can get this instead
with this change:
Add line 129 of /administrator/components/com_associations/views/associations/tmpl/default.php
<?php if (!$canCheckin && $isCheckout) : ?>
<?php echo JHtml::_('jgrid.checkedout', $i, $item->editor, $item->checked_out_time, 'associations.'); ?>
<?php endif; ?>
just before
<?php if ($canCheckin && $isCheckout) : ?>
<?php echo JHtml::_('jgrid.checkedout', $i, $item->editor, $item->checked_out_time, 'associations.', $canCheckin); ?>
<?php endif; ?>
Note: I am preparing a PR to solve also a checked out issue in the side by side view.
I have tested this item
Patch test successfully, with JM patch modification.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15873.
I have tested this item
Patch ok for me
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15873.
| Status | Pending | ⇒ | Ready to Commit |
RTC after two successful tests.
@franz-wohlkoenig
We wait for @rdeutz to merge rdeutz#14
| Labels |
Added:
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15873.
Note: as soon as we are ready to release 3.7.1, we will let it know to TTs about the new string, but I was unable for now to reproduce an error using it.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-05-10 14:54:25 |
| Closed_By | ⇒ | infograf768 |
Unfortunately, I had to change the language file, I will merge this anyway even if we don't have the time to let all translation teams translate the term.
@brianteeman can you have a look at the sentence I would call english :-)