? Pending

User tests: Successful: Unsuccessful:

avatar joomdonation
joomdonation
7 May 2017

Pull Request for Issue # .

Summary of Changes

This simply PR converts com_messages to namespace MVC for Joomla 4

Testing Instructions

Unfortunately, this is currently not testable because the popup window to select a user to send private message is broken in Joomla 4. I had to change the value using inspector to test the extension while working o this conversion

For now, guess @wilsonge will have to review the code to merge.

avatar joomdonation joomdonation - open - 7 May 2017
avatar joomdonation joomdonation - change - 7 May 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 7 May 2017
Category Administration com_messages
avatar dgt41
dgt41 - comment - 7 May 2017

@joomdonation the base code for fixing the modals is already RTC: #15374
Then we need to specify the width/height for each modal to have a workable modal

avatar joomdonation
joomdonation - comment - 7 May 2017

George needs to merge it then. There is also a SQL error when a user group is selected in the popup, but of course, it is not related to your PR.

avatar wilsonge wilsonge - change - 7 May 2017
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-05-07 11:53:10
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 7 May 2017
avatar wilsonge wilsonge - merge - 7 May 2017
avatar wilsonge
wilsonge - comment - 8 May 2017

Fixed the SQL Error :) Still needs @dgt41 's fix for the javascript issue

avatar joomdonation
joomdonation - comment - 8 May 2017

He said it is RTC. So maybe you can check and merge that one. People have been opening issues related to it.

Add a Comment

Login with GitHub to post a comment