? ? Pending

User tests: Successful: Unsuccessful:

avatar PhilETaylor
PhilETaylor
5 May 2017

Pull Request for Issue #15827 .

Summary of Changes

Allow Joomla to be extended with JDEBUG defined by developers when in a sub folder without FOF moaning and fatal erroring.

Testing Instructions

Apply PR and check Joomla operates as normal.

Create api.php in Joomla tmp folder with content

<?php
define('_JEXEC', 1);
define('JPATH_BASE', realpath('../'));
ini_set('display_errors', '1');
error_reporting(E_ALL);
define('JDEBUG', 1);
include_once JPATH_BASE . '/includes/defines.php';
include_once JPATH_BASE . '/includes/framework.php';
include_once JPATH_BASE . '/libraries/joomla/factory.php';

Expected result

No errors on running

Actual result

PHP Fatal error:  Uncaught Error: Call to a member function logAddLogger() on null in /Users/phil/Sites/joomla-cms/libraries/fof/include.php:26
Stack trace:
#0 /Users/phil/Sites/joomla-cms/libraries/cms.php(45): include_once()
#1 /Users/phil/Sites/joomla-cms/includes/framework.php(23): require_once('/Users/phil/Sit...')
#2 /Users/phil/Sites/joomla-cms/tmp/api.php(8): include_once('/Users/phil/Sit...')
#3 {main}
  thrown in /Users/phil/Sites/joomla-cms/libraries/fof/include.php on line 26

Documentation Changes Required

None

avatar PhilETaylor PhilETaylor - open - 5 May 2017
avatar PhilETaylor PhilETaylor - change - 5 May 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 5 May 2017
Category Libraries
avatar PhilETaylor PhilETaylor - change - 5 May 2017
The description was changed
avatar PhilETaylor PhilETaylor - edited - 5 May 2017
avatar Fedik
Fedik - comment - 7 May 2017

I have tested this item successfully on ec7f86a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15843.

avatar Fedik Fedik - test_item - 7 May 2017 - Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 23 May 2017

@PhilETaylor i have Debug enabled + api.php in tmp-Folder but didn't get PHP Fatal error:.

avatar PhilETaylor
PhilETaylor - comment - 24 May 2017

Is your error_reporting in PHP disabled or set to E_ALL ? is display_errors=on in your php.ini?

even with the latest staging I still get this when running the example code:

Fatal error: Uncaught Error: Call to a member function logAddLogger() on null in /Users/phil/Sites/joomla-cms/libraries/fof/include.php:26 Stack trace: #0 /Users/phil/Sites/joomla-cms/libraries/cms.php(45): include_once() #1 /Users/phil/Sites/joomla-cms/includes/framework.php(23): require_once('/Users/phil/Sit...') #2 /Users/phil/Sites/joomla-cms/tmp/api.php(8): include_once('/Users/phil/Sit...') #3 {main} thrown in /Users/phil/Sites/joomla-cms/libraries/fof/include.php on line 26
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 24 May 2017

@PhilETaylor thanks for Answer. As i don't know how to set this Values this Issue is about my Knowledge.

avatar rdeutz rdeutz - change - 27 May 2017
Labels Added: ?
avatar PhilETaylor
PhilETaylor - comment - 12 Nov 2018

@franz-wohlkoenig this just needs another test to get to RTC if you have time please :) (@or @SharkyKZ as you seem active presently)

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 12 Nov 2018

@PhilETaylor

As i don't know how to set this Values this Issue is about my Knowledge.

avatar PhilETaylor
PhilETaylor - comment - 12 Nov 2018

The testing instructions are in the PR text, under "testing instructions"....

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 12 Nov 2018

i meant comments starting #15843 (comment)

avatar PhilETaylor
PhilETaylor - comment - 12 Nov 2018

What Joomla version are you testing against?

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 12 Nov 2018

Actually i'm testing not as the "how to set this Values this Issue is about my Knowledge".

avatar SharkyKZ
SharkyKZ - comment - 12 Nov 2018

I have tested this item successfully on ef3e2f3

Changes applied manually.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15843.

avatar SharkyKZ SharkyKZ - test_item - 12 Nov 2018 - Tested successfully
avatar Quy Quy - change - 12 Nov 2018
Status Pending Ready to Commit
avatar Quy
Quy - comment - 12 Nov 2018

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15843.

avatar mbabker mbabker - close - 13 Nov 2018
avatar mbabker mbabker - merge - 13 Nov 2018
avatar mbabker mbabker - change - 13 Nov 2018
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-11-13 00:01:16
Closed_By mbabker
Labels Added: ?

Add a Comment

Login with GitHub to post a comment