@zero-24 can you advise on the best way to make the change required by drone please

@zero-24 ignore that request - i figured it out

This is fully backwards compatible

This one looks not B/c currently as we reorder the options to be passed. I would agree if we add the new option at the end of the method signature with a default value but currently this looks for me as a b/c break.

:( any suggestions to address that

Like i said above move the new option (title) to the end of the method signature with a default value :)

@zero-24 unfortunately that doesn't work or I would have done it unless I misunderstood

It should work ;) i can send you a PR tomorrow.

I tested this PR with jevents and acymailing which both use grid and it worked fine as far as I could see

Discovered a bug in some views where they dont use item->title but item->name such as com_contact

Fixed

I understand the changes I need to make for b/c now.and will do it this afternoon

?

thanks @C-Lodder and @dgt41 should be ready for testing now

@yvesh @rdeutz does this need unit tests?

No, testing html output doesn't makes so much sense.

ok - thanks - wasnt sure as it touched a library file - thanks for confirming

Please check if these files need to be updated. Thanks.
\administrator\components\com_cache\views\cache\tmpl\default.php (line 59)
\administrator\components\com_installer\views\discover\tmpl\default_item.php (line 14)
\installation\view\languages\tmpl\default.php (line 95)
\administrator\templates\hathor\html\com_cache\cache\default.php (liine 64)
\administrator\components\com_media\views\medialist\tmpl\details_folders.php (line 19)
\administrator\components\com_media\views\medialist\tmpl\thumbs_folders.php (line 18)
\administrator\templates\isis\html\com_media\medialist\thumbs_folders.php (line 18)
\installation\view\languages\tmpl\default.php (line 95)

@Quy
Missing these was deliberate as media manager is being replaced and hathor is virtually dead

\administrator\templates\hathor\html\com_cache\cache\default.php (liine 64)
\administrator\components\com_media\views\medialist\tmpl\details_folders.php (line 19)
\administrator\components\com_media\views\medialist\tmpl\thumbs_folders.php (line 18)
\administrator\templates\isis\html\com_media\medialist\thumbs_folders.php (line 18)

These ones are not using grid.id and beyond the scope of this PR
\administrator\components\com_cache\views\cache\tmpl\default.php (line 59)
\administrator\components\com_installer\views\discover\tmpl\default_item.php (line 14)
\installation\view\languages\tmpl\default.php (line 95)
\installation\view\languages\tmpl\default.php (line 95)

Please note that with the Select, the title is Red & Blue and the rest is Red & Blue. I am not sure what is the best way to escape the title value. Maybe escape it in the parameter like this:
<?php echo JHtml::_('grid.id', $i, $item->id, false, 'cid', 'cb', $this->escape($item->title)); ?>

<td class="center">
        <label for="cb0"><span class="element-invisible">Select Red & Blue</span></label><input type="checkbox" id="cb0" name="cid[]" value="2" onclick="Joomla.isChecked(this.checked);" />							</td>
<td class="center">
        <div class="btn-group">
                <a class="btn btn-micro active hasTooltip" href="javascript:void(0);" onclick="return listItemTask('cb0','tags.unpublish')" title="Unpublish Item"><span class="icon-publish"></span></a>									<button data-toggle="dropdown" class="dropdown-toggle btn btn-micro"><span class="caret"></span><span class="element-invisible">Actions for: Red &amp; Blue</span></button><ul class="dropdown-menu"><li><a href = "javascript://" onclick="listItemTask('cb0', 'tags.archive')"><span class="icon-archive"></span> Archive</a></li><li><a href = "javascript://" onclick="listItemTask('cb0', 'tags.trash')"><span class="icon-trash"></span> Trash</a></li></ul>								</div>
</td>
<td>
                                                                                                                                                                                                                <a href="/joomla-cms/administrator/index.php?option=com_tags&amp;task=tag.edit&amp;id=2">
                        Red &amp; Blue</a>
                                                                        <span class="small" title="red">
                                                                                                (<span>Alias</span>: red)																	</span>
</td>

@Quy think it would be best to do it in the function itself. Means less code too.

@C-Lodder In another call, the escape is done outside the function:
echo JHtml::_('actionsdropdown.render', $this->escape($item->title));

I dont see a reason for this not to be merged - the comments above appear to be beyond the scope of this PR

To reproduce, edit an article and click Versions button.

PHP Notice:  Undefined property: stdClass::$id in C:\xampp\htdocs\joomla-cms\administrator\components\com_contenthistory\views\history\tmpl\modal.php on line 145

What's happening with this?

@C-Lodder I had hope the a11y team would have commented

Lost interest and the a11y team show no interest in improving a11y

re-opening to see if it is still valid

as it was for staging and I did it for 4 already closing permanently now ;)