? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
5 May 2017

Recent changes have aimed to improve the accessibility where we use font icons to ensure that their value is not "read" by assistive technology and only the associated text is read.

The buttons in the version history modal are not constructed the same as other buttons in Joomla and when we switch to a mobile device the displayed text is hidden.

This means that with the current markup it is all ok for accessibility on a desktop because we have the associated text but as this text is hidden on a phone the assistive technology has no way of identifying the buttons.

This PR adds the aria-label attribute to the buttons to ensure that assistive technology can always "read" the button at all screensizes.

Thanks to @fuzzbomb for spotting this and his guidance on resolving this

avatar brianteeman brianteeman - open - 5 May 2017
avatar brianteeman brianteeman - change - 5 May 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 5 May 2017
Category Administration com_content com_contenthistory
3a3f51b 5 May 2017 avatar brianteeman typo
avatar brianteeman brianteeman - change - 5 May 2017
Labels Added: ?
avatar Quy
Quy - comment - 5 May 2017

I have tested this item successfully on 3a3f51b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15828.

avatar Quy Quy - test_item - 5 May 2017 - Tested successfully
avatar C-Lodder
C-Lodder - comment - 8 May 2017

I have tested this item successfully on 3a3f51b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15828.

avatar C-Lodder C-Lodder - test_item - 8 May 2017 - Tested successfully
avatar franz-wohlkoenig franz-wohlkoenig - change - 8 May 2017
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 8 May 2017

RTC after two successful tests.

avatar rdeutz rdeutz - change - 22 May 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-05-22 18:34:58
Closed_By rdeutz
Labels Added: ?
avatar rdeutz rdeutz - close - 22 May 2017
avatar rdeutz rdeutz - merge - 22 May 2017
avatar brianteeman
brianteeman - comment - 22 May 2017

Thanks

Add a Comment

Login with GitHub to post a comment