Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#1578] - [fix] Various RTL fixes + 320px viewport media queries

Success

User tests: Successful: Unsuccessful:

avatar phproberto
phproberto
23 Jul 2013

I reviewed the toolbar again. This pull request:

  • Ensures that compiled CSS code is the same than generated from LESS files
  • Fixes toolbar buttons width in 320px width resolutions
  • Fixes toolbar buttons in mobile devices on RTL languages
avatar phproberto phproberto - open - 23 Jul 2013
avatar phproberto
phproberto - comment - 23 Jul 2013

Testing instructions

  • Ensure that you are using the latest compiled CSS files running from your site folder: php build/generatecss.php. This is IMPORTANT because some bugs only occur with the compiled CSS.
  • Change browser to a 320px width resolution. You will see that toolbar displays this bug: 320_viewport
  • Change the language to RTL editing the file administrator/language/en-GB/en-GB.xml and replacing:
<rtl>0</rtl>

with:

<rtl>1</rtl>

  • Go to article manager and notice that the toolbar is missing a rigth margin:
    rtl_margin_rigth

  • Now in the same RTL language change resolution to any mobile viewport (480px width for example). You will see something like:
    rtl_480_viewport

  • Apply the patch and ensure that all the previous bugs are fixed.
avatar phproberto phproberto - close - 24 Jul 2013
avatar Bakual Bakual - reference | - 30 Jul 13
avatar garyamort garyamort - reference | - 2 Dec 13

Add a Comment

Login with GitHub to post a comment