? ? Pending

User tests: Successful: Unsuccessful:

avatar ciar4n
ciar4n
3 May 2017

Pull Request for Issue #15578 .

Summary of Changes

#toolbar .btn-success has a set width. This PR removes this and applies it to just the 'New' button.

Testing Instructions

See #15578. Easiest way to test is to use your browser inspector. Add btn-success to any button within the toolbar (eg. btn btn-small btn-success), then change the button text and ensure the text does not wrap.

Documentation Changes Required

None

avatar ciar4n ciar4n - open - 3 May 2017
avatar ciar4n ciar4n - change - 3 May 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 3 May 2017
Category Administration Templates (admin)
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 3 May 2017

I have tested this item successfully on dc8e3b2


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15760.

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 3 May 2017 - Tested successfully
avatar brianteeman
brianteeman - comment - 3 May 2017

I have tested this item successfully on dc8e3b2


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15760.

avatar brianteeman brianteeman - test_item - 3 May 2017 - Tested successfully
avatar dgt41
dgt41 - comment - 3 May 2017

@ciar4n why not min-width? (also to keep the current layout)

avatar ciar4n
ciar4n - comment - 3 May 2017

@dgt41 To be honest I never thought of it. Instead I set the width to just #toolbar-new.

Your right.. these buttons look strange if the text is short due to the different icon styling. I'll change it.

Quick code review should be enough for RTC.

avatar ciar4n ciar4n - change - 3 May 2017
Labels Added: ?
avatar franz-wohlkoenig franz-wohlkoenig - change - 3 May 2017
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 3 May 2017

RTC after two successful tests.

avatar rdeutz rdeutz - change - 22 May 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-05-22 18:39:22
Closed_By rdeutz
Labels Added: ?
avatar rdeutz rdeutz - close - 22 May 2017
avatar rdeutz rdeutz - merge - 22 May 2017

Add a Comment

Login with GitHub to post a comment