? Pending

User tests: Successful: Unsuccessful:

avatar Bakual
Bakual
2 May 2017

The new calendar can now show a time field which the old calendar couldn't. Unfortunately this new feature is enabled by default which means the calendar now shows a time field for all extensions using it regardless if the field expects a time part or not. This is a wrong behavior due to (at least) two points:

  • The attribute is named showtime which implies that if not present it would not show a time. But actually to show the time you can omit it completely and to hide it you need to add showtime="false"
  • The default format attribute for the calendar field is %Y-%m-%d, which means it expects only the date.

Summary of Changes

This PR changes the default value for that attribute to false instead of true.

Testing Instructions

Expected result

The calendar shows no time field

Actual result

The calendar shows a time field

Further Testing

  • Make sure saving works and doesn't give you a warning, especially when testing with another language where the date format is different to english (eg german).
  • Test with various combinations of the translateformat, showtime and format attributes. For example removing them all should result in the date only.

Documentation Changes Required

None
Obviously, this is not fully backward compatible with 3.7.0 as it changes the default behavior. Imho it isn't a big deal as it only affects the display of the calendar popup.

avatar Bakual Bakual - open - 2 May 2017
avatar Bakual Bakual - change - 2 May 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 2 May 2017
Category Libraries
avatar Bakual Bakual - change - 2 May 2017
The description was changed
avatar Bakual Bakual - edited - 2 May 2017
avatar Didldu-Florian
Didldu-Florian - comment - 2 May 2017

I have tested this item successfully on 20fb0a9

avatar chmst
chmst - comment - 2 May 2017

I have tested this item successfully on 20fb0a9

Tested Successfully. In my opinion this does not cause a b/c break but fix a b/c break ´.
My components used the former calendar JFormfield. There were no input fields for the time (and I do not want them there). After upgrading from 3.6 to 3.7 the users did not know how to work. Time ist not needed there, it caused some confusion. Especially because after selecting the date the calendar is not closed automatically as it was in 3.6.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15745.

avatar chmst chmst - test_item - 2 May 2017 - Tested successfully
avatar franz-wohlkoenig franz-wohlkoenig - change - 3 May 2017
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 3 May 2017

RTC after two successful tests.

avatar rdeutz rdeutz - change - 3 May 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-05-03 08:35:13
Closed_By rdeutz
Labels Added: ?
avatar rdeutz rdeutz - close - 3 May 2017
avatar rdeutz rdeutz - merge - 3 May 2017

Add a Comment

Login with GitHub to post a comment