User tests: Successful: Unsuccessful:
The new calendar can now show a time field which the old calendar couldn't. Unfortunately this new feature is enabled by default which means the calendar now shows a time field for all extensions using it regardless if the field expects a time part or not. This is a wrong behavior due to (at least) two points:
showtime
which implies that if not present it would not show a time. But actually to show the time you can omit it completely and to hide it you need to add showtime="false"
%Y-%m-%d
, which means it expects only the date.This PR changes the default value for that attribute to false
instead of true
.
publish_up
field (https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_content/models/forms/article.xml#L102-L109). Remove the showtime
attribute.The calendar shows no time field
The calendar shows a time field
translateformat
, showtime
and format
attributes. For example removing them all should result in the date only.None
Obviously, this is not fully backward compatible with 3.7.0 as it changes the default behavior. Imho it isn't a big deal as it only affects the display of the calendar popup.
Status | New | ⇒ | Pending |
Category | ⇒ | Libraries |
I have tested this item
Tested Successfully. In my opinion this does not cause a b/c break but fix a b/c break ´.
My components used the former calendar JFormfield. There were no input fields for the time (and I do not want them there). After upgrading from 3.6 to 3.7 the users did not know how to work. Time ist not needed there, it caused some confusion. Especially because after selecting the date the calendar is not closed automatically as it was in 3.6.
Status | Pending | ⇒ | Ready to Commit |
RTC after two successful tests.
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-05-03 08:35:13 |
Closed_By | ⇒ | rdeutz | |
Labels |
Added:
?
|
I have tested this item✅ successfully on 20fb0a9