[#15743] - Code cleanup
- Closed
- 21 May 2019
- Medium
- Build: staging
- # 15743
- Diff
- demis-palma:profiler
- Success continuous-integration/drone/pr the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
- Error continuous-integration/jenkins/pr-merge This commit cannot be built Details
User tests: Successful: Unsuccessful:
The PHPdoc declares the variable as "double"
@param double $startTime
but the method initialises its default value with an "integer" instead
$startTime = 0
Summary of Changes
Changed the default value to type double
Testing Instructions
To be merged on review
| Status | New | ⇒ | Pending |
| Category | ⇒ | Libraries |
| Labels |
Added:
?
|
||
closed for Reason stated above. Pull Request can always reopened if needed.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-05-11 04:26:07 |
| Closed_By | ⇒ | franz-wohlkoenig | |
| Labels |
Removed:
J3 Issue
|
||
There is a difference, the var gets initialized as float if 0.0 so this pr is correct
| Status | Closed | ⇒ | New |
| Closed_Date | 2019-05-11 04:26:07 | ⇒ | |
| Closed_By | franz-wohlkoenig | ⇒ |
| Status | New | ⇒ | Pending |
The file moved to libraries/src/Profiler/Profiler.php in the meantime may @demis-palma could rebase it?
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-05-21 14:40:59 |
| Closed_By | ⇒ | Quy |
| Closed_Date | 2019-05-21 14:40:59 | ⇒ | 2019-05-21 14:41:03 |
| Closed_By | Quy | ⇒ | joomla-cms-bot |
Set to "closed" on behalf of @Quy by The JTracker Application at issues.joomla.org/joomla-cms/15743
Closing in favor of PR #24971
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15743.
Closing in favor of PR #24971
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15743.
Tested with
0and0.0and the result is always0. Thus, it doesn't make a difference. Close PR?