J3 Issue ?
avatar mbabker
mbabker
2 May 2017

A lot of our test coverage is coming from the fact that there are a lot of deep rooted internal couplings and static method calls which cannot be mocked. This is massively throwing off our coverage reports and misrepresenting our actual state of the test suite. We need to work through the test suite to explicitly mark what the test cases are actually covering so we stop having leakage of covered code through test cases that aren't designed to be covering certain methods (i.e. JApplicationCmsTest shouldn't be covering the JDate constructor). This will help to better represent what we have explicit test cases and coverage for and therefore help us to better refine our test suite.

https://twitter.com/mbabker/status/859412612471300096

avatar mbabker mbabker - open - 2 May 2017
avatar joomla-cms-bot joomla-cms-bot - change - 2 May 2017
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 2 May 2017
avatar franz-wohlkoenig franz-wohlkoenig - change - 2 May 2017
Category Unit Tests
avatar PhilETaylor
PhilETaylor - comment - 2 May 2017

If only...

But still the project accepts new features and new code without accompanying them with valid unit tests... until this is addressed, this problem will only grow and grow... :(

avatar mbabker
mbabker - comment - 2 May 2017

We've gotta start somewhere. When you have 1900 cases for the JDate constructor and 1896 of them are from tests that cover code that uses JDate (as in they shouldn't be covering that), you're basically left with not knowing what code you're actually testing.

avatar franz-wohlkoenig franz-wohlkoenig - change - 2 May 2017
Status New Discussion
avatar brianteeman brianteeman - labeled - 25 Mar 2018
avatar brianteeman brianteeman - change - 25 Mar 2018
Labels Added: J3 Issue
avatar mbabker
mbabker - comment - 3 Apr 2018

Most tests are gone in 4.0. No point in touching 3.x tests.

avatar mbabker mbabker - change - 3 Apr 2018
Status Discussion Closed
Closed_Date 0000-00-00 00:00:00 2018-04-03 12:11:41
Closed_By mbabker
avatar mbabker mbabker - close - 3 Apr 2018

Add a Comment

Login with GitHub to post a comment