User tests: Successful: Unsuccessful:
Pull Request for Issue #15737 .
Fixed JApplicationWeb to generate the redirection headers with the same headers API that it is called on respond().
Now, it is generating the headers adding them as a raw header. If the there's an extra Status (e.g. a 201 defined with setHeader), it replaces the 303.
Test that all redirections work Ok. For example, when items are saved.
This issue was discovered with an extension running on FOF2 (the controller defined a Status 201 and, in a second step, calls a redirection). So, any extension running FOF2 is also a good test (save items).
All redirections work OK.
When multiple statuses are defined, the 303 redirection is lost and the status defined with setHeader('Status'... overrides any previous header('HTTP 1.1 303 See other');
Status | New | ⇒ | Pending |
Category | ⇒ | Libraries |
anibalsanchez#1 Adds a unit test for the bug fix being made
Labels |
Added:
?
|
Category | Libraries | ⇒ | Libraries Unit Tests |
Labels |
Added:
?
|
@anibalsanchez you need to look at the unit test fails here
Hi @wilsonge ,
I've just fixed the issues on the unit tests. Some notes:
The translation of the 'status' to HTTP/1.1 was not sending the parameters required by JApplicationCmsTest/testRedirect.
I have tested this item
Would be good to have more tests, if someone needs a component, this one http://babioon.com/en/component/ars/repository/babioon-event/babioon-event-3-0-0/babioon-event-3-0-0.html fails
I have tested this item
Status | Pending | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-05-15 09:11:21 |
Closed_By | ⇒ | rdeutz |
Unit test failures need investigating. The
HTTP/1.1
being repeated in the status code definitely looks unintended?