[#15738] - Redirection fails on multiple status values #15737
- Fixed in Code Base
- 15 May 2017
- Medium
- Build: staging
- # 15738
- Diff
- anibalsanchez:staging
User tests: Successful: Unsuccessful:
Pull Request for Issue #15737 .
Summary of Changes
Fixed JApplicationWeb to generate the redirection headers with the same headers API that it is called on respond().
Now, it is generating the headers adding them as a raw header. If the there's an extra Status (e.g. a 201 defined with setHeader), it replaces the 303.
Testing Instructions
Test that all redirections work Ok. For example, when items are saved.
This issue was discovered with an extension running on FOF2 (the controller defined a Status 201 and, in a second step, calls a redirection). So, any extension running FOF2 is also a good test (save items).
Expected result
All redirections work OK.
Actual result
When multiple statuses are defined, the 303 redirection is lost and the status defined with setHeader('Status'... overrides any previous header('HTTP 1.1 303 See other');
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
anibalsanchez#1 Adds a unit test for the bug fix being made
| Labels |
Added:
?
|
||
| Category | Libraries | ⇒ | Libraries Unit Tests |
| Labels |
Added:
?
|
||
@anibalsanchez you need to look at the unit test fails here
Hi @wilsonge ,
I've just fixed the issues on the unit tests. Some notes:
The translation of the 'status' to HTTP/1.1 was not sending the parameters required by JApplicationCmsTest/testRedirect.
- In JApplicationWebTest/testRedirectWithExistingStatusCode, setHeader('status', 201) can also be setHeader('Status', 201), since setHeader is case-sensitive. So, the case difference produces different tests results. I have created testRedirectWithExistingStatusCode1 and testRedirectWithExistingStatusCode2 to check the results of status and Status.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15738.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15738.
Would be good to have more tests, if someone needs a component, this one http://babioon.com/en/component/ars/repository/babioon-event/babioon-event-3-0-0/babioon-event-3-0-0.html fails
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15738.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-05-15 09:11:21 |
| Closed_By | ⇒ | rdeutz |
Unit test failures need investigating. The
HTTP/1.1being repeated in the status code definitely looks unintended?