Feeling Lucky
[#1572] - Adding filters in back-end Installation Discover view for 3.x
- Closed
- 3 Aug 2013
- Medium
- Build: master
- # 1572
- Diff
- gunjanpatel:discover_filter_j3
- Success default The Travis CI build passed Details
User tests: Successful: Unsuccessful:
- It was very hard to find and install from discover view when having a large number of items.
- I have added filters in discover view like we have in other Joomla! view.
- Here I have attached screen dump of the filters,
- To test this PR
- Apply this patch https://github.com/joomla/joomla-cms/pull/1572.diff
- Try to discover the items in installation/discover view.
- Try to filter discover list with any sting and filter by location, type and folder using select box.
gunjanpatel
- comment
- 22 Jul 2013
infograf768
- comment
- 22 Jul 2013
2 remarks
1. Any reason to delete
protected $context = 'cominstaller.discover';
- Looks like $app = JFactory::getApplication(); is called twice in public function discover_install()
gunjanpatel
- comment
- 23 Jul 2013
Thanks @infograf768 for review.
2 . Looks like $app = JFactory::getApplication(); is called twice in public function discover_install()
Yes, you are right. I have removed $app = JFactory::getApplication(); from line no L173.
1 . Any reason to delete
protected $context = 'cominstaller.discover';
Actually, I didn't found usage of this variable in this file.
gunjanpatel
- comment
- 5 Aug 2013
Thanks a lot @infograf768
garyamort
-
Please create a tracker on joomlacode and cross reference here