[#15717] - Implementation of the new Exception-Handling
- Fixed in Code Base
- 22 May 2017
- Very low
- Build: staging
- # 15717
- Diff
- Didldu-Florian:staging
User tests: Successful: Unsuccessful:
Implementation of the new Exception-Handling
Summary of Changes
Removed unneeded unreachable statement 8b46567
Exception code must be second paramter ea18fe7
Implemented new exception handling (JError is deprecated) 523eab6
Implemented new exception handling (JError is deprecated). e66b103
Status Code for "not authorized" should be 403 Forbidden. e66b103
Testing Instructions
Tested should be all backend components
A: Check for access
Change access level and try to access componentes.
Try to runn an error.
B: Check for errors
Tested should be check for errors in view.html.php files of all backend components.
Try to runn an error.
Expected result
A: Error message should be thrown
Exception Error 403 JERROR_ALERTNOAUTHOR
B: Error message should be thrown
Exception Error 'Status Code' $error
Actual result
Implementation of the error handling still panding in some components, Exception-Handling works already fine in some components. Actual result is the same, but improved with Exception-Handling,
and not with Joomla Framework outdated deprecated JError.
Implementation of the new Exception-Handling
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_admin com_associations com_banners com_cache com_categories com_checkin com_contact com_content com_contenthistory com_fields com_finder |
| Priority | Medium | ⇒ | Very low |
| Category | Administration com_admin com_associations com_banners com_cache com_categories com_checkin com_contact com_content com_contenthistory com_fields com_finder | ⇒ | Administration com_ajax |
| Category | Administration com_ajax | ⇒ | com_admin com_users |
| Category | com_admin com_users | ⇒ | com_admin com_fields com_users |
| Category | com_admin com_users com_fields | ⇒ | Administration com_admin com_associations com_banners com_cache com_categories com_checkin com_contact com_content com_contenthistory com_fields com_finder com_users |
| Category | com_admin com_users com_fields Administration com_associations com_banners com_cache com_categories com_checkin com_contact com_content com_contenthistory com_finder | ⇒ | Administration com_admin com_associations com_banners com_cache com_categories com_checkin com_contact com_content com_contenthistory com_fields com_finder |
Should this pr not be against the 4.0 branch? Just to be on the safe side to not introduce unintended behavior.
If we were in library level APIs I might say yes. But as this is in components and is functionally similar, it's OK to me. The only possible side effect is someone having a custom Exception handler registered would get more Exceptions passed through it than the current JError callback behavior.
Exception-Handling has already proven itself in some places.
Such as. here: etc.. It´s nothing new.
administrator/components/com_menus/views/item/view.html.php#L68
administrator/components/com_languages/views/override/view.html.php#L6
I have become aware of this, because JED Extensions Checker did marks this already. Exception handling is the cleanest solution to my view on components level, much better than enque message suggestion. So, I also think how @mbabker
Hope it is okay, at this time @laoneo. And extension developers could slowly get used to the standard in her components.
I absolutely understand your arguments. For me stuff like that belongs to a minor release and not a patch release. But I guess at the end of the day we will hurt nobody if it goes into staging.
RTC?
There are 2 successful tests. See 2nd posting.
If after a Test are Changes, it doesn't count. See at Bottom "JTracker/HumanTestResults".
There were no more changes after chmst tested.
| Status | Pending | ⇒ | Ready to Commit |
RTC.
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-05-22 18:46:16 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
?
|
||
I have tested this item✅ successfully on e66b103
Successfully tested for the sysinfo view in com_admin. On inspection the other changes should be all right too.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15717.