[#15714] - Double Quotes Not Escaped Properly
- Fixed in Code Base
- 22 May 2017
- Medium
- Build: staging
- Easy Test
- # 15714
- Diff
- imanickam:patch-3
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
No issue tracker for this.
Summary of Changes
Double Quotes Not Escaped Properly in the Language String COM_INSTALLER_NO_INSTALLATION_PLUGINS_FOUND
Original Language String:
COM_INSTALLER_NO_INSTALLATION_PLUGINS_FOUND="No installation plugin has been enabled. At least one must be enabled to be able to use the installer. Go to the Plugin Manager to enable the plugins."
Proposed Language String:
COM_INSTALLER_NO_INSTALLATION_PLUGINS_FOUND="No installation plugin has been enabled. At least one must be enabled to be able to use the installer. Go to the <a href='index.php?option=com_plugins&view=plugins&filter[folder]=installer' title="Plugin Manager">Plugin Manager to enable the plugins."
Reason:
The double quotes enclosing the text string "Plugin Manager" is not escaped properly wither with "QQ" (current usage) or " (future usage). Because of this, the HTML generated where this language string is used is shown as below:
Notice the new attribute master next to the title attribute.
With the fully escaped double quotes, the HTML would like the following:
Testing Instructions
- Login to the site's back-end
- Go to the screen "Plugins" (Extensions => Plugins)
- Disable all the plugins of the type "Installer"
- Go to the screen "Extensions: Install" (Extensions => Manage -> Install"
- You will see a warning notice about no installation plugins are enabled
- Inspect the HTML created for the Warning message
Expected result
Review the summary of changes
Actual result
Review the summary of changes
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Language & Strings |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15714.
| Easy | No | ⇒ | Yes |
I think for translators using services like Transifex or Crowdin it is still safer to use either single quotes or the html entity for double quotes ".
Good Point... There should be some standard guidelines for using the quote (either single or double) in the language strings.
html entity can't be used in href
@imanickam
As this is not urgent and would be the only lang change for 3.7.1 (if I do not mistake), I think we can delay merging until >3.7.1. I nevertheless suggest to use single quotes instead of escaped double quotes in this case.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15714.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15714.
| Status | Pending | ⇒ | Ready to Commit |
RTC after two successful tests.
@infograf768 I just read that there might be issues with single quotes in href too (jjk - VirtueMart):
http://forum.virtuemart.net/index.php?topic=137335.msg481063#msg481063
I have no issue when using single quotes in href. All depends I guess how the href is obtained. In our lang strings, when using them to link to a specific page, they are perfectly OK.
In our lang strings, when using them to link to a specific page, they are perfectly OK.
Agreed! I think I had copied a syntax error in one of my test cases. Single quotes should work.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15714.
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-05-22 19:04:50 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
?
|
||
I think for translators using services like Transifex or Crowdin it is still safer to use either single quotes or the html entity for double quotes
".This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15714.