? ? ? Pending

User tests: Successful: Unsuccessful:

avatar sanderpotjer
sanderpotjer
30 Apr 2017

Summary of Changes

With #4975 and #6978 the action core.options is added to components, but not to the Permissions settings in the Global Configuration. This Pull Request is adding this action to the Global Configuration Permissions so users can set the permission for this actions on the global level, rather then having to set the permission for each component individually.

Testing Instructions

  1. Confirm the "Configure Options Only" is not available in the Permission tab of the Global Configuration, but available for components like com_content and com_contact.
  2. Apply patch
  3. Go to the Article Manager and confirm the "Configure Options Only" is not set for the Manager group (default installation).

screen_shot_2017-04-30_at_21_15_52

4) Check if the "Configure Options Only" is now available in the Permission tab of the Global Configuration and set it to allowed:

screen_shot_2017-04-30_at_21_16_28

5) Go back to the Article Manager Permissions and confirm the action is now allowed, by inheriting the Global Configuration setting

screen_shot_2017-04-30_at_21_16_41

The "Configure Options Only" should also be visible in the Group and User "Advanced Permissions Report"

avatar sanderpotjer sanderpotjer - open - 30 Apr 2017
avatar sanderpotjer sanderpotjer - change - 30 Apr 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 30 Apr 2017
Category Administration com_config Language & Strings
avatar sanderpotjer sanderpotjer - change - 30 Apr 2017
Labels Added: ? ?
avatar brianteeman
brianteeman - comment - 30 Apr 2017

+COM_CONFIG_ACTION_OPTIONS_DESC="Allows users in the group to edit the options except the permissions of any extension."

I am not 100% sure what you mean by this but shouldnt it be component not extension

avatar sanderpotjer
sanderpotjer - comment - 30 Apr 2017

@brianteeman I kept the translation in line with the other action descriptions. Happy to change it, but all other actions have "extension" as description instead of "component". Other part is simply a copy of "JACTION_OPTIONS_COMPONENT_DESC".

avatar brianteeman
brianteeman - comment - 30 Apr 2017

ok fair enough - consistency always wins.

looks like an error to me but that's beyond the scope of this PR.

avatar alikon
alikon - comment - 1 May 2017

I have tested this item successfully on 8a8fcd8


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15709.

avatar alikon alikon - test_item - 1 May 2017 - Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 1 May 2017

I have tested this item successfully on 8a8fcd8


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15709.

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 1 May 2017 - Tested successfully
avatar franz-wohlkoenig franz-wohlkoenig - change - 1 May 2017
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 1 May 2017

RTC after two successful tests.

avatar PhilETaylor
PhilETaylor - comment - 2 May 2017

continuous-integration/appveyor/pr — AppVeyor build failed

Are we just going to ignore this then?

avatar Bakual
Bakual - comment - 2 May 2017

@PhilETaylor Looks like that error is unrelated to this PR as it failed to download an extern file needed to run the test. If anyone knows how to restart that job... ?

avatar PhilETaylor
PhilETaylor - comment - 2 May 2017

Apparently #15706

avatar rdeutz rdeutz - change - 22 May 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-05-22 19:23:43
Closed_By rdeutz
Labels Added: ?
avatar rdeutz rdeutz - close - 22 May 2017
avatar rdeutz rdeutz - merge - 22 May 2017

Add a Comment

Login with GitHub to post a comment