[#15704] - update to phpass 0.5
- Fixed in Code Base
- 23 May 2017
- Medium
- Build: staging
- # 15704
- Diff
- photodude:patch-10
User tests: Successful: Unsuccessful:
Pull Request for Issue new version of phpass .
Summary of Changes
Update to current version of phpass found at http://cvsweb.openwall.com/cgi/cvsweb.cgi/projects/phpass/PasswordHash.php?r1=1.9#rev1.9
additional release note information in the official announcment
http://www.openwall.com/lists/announce/2017/05/07/1
- Dropped PHP 3 & 4 support in favor of PHP 7 friendliness (no deprecation warnings). Specifically:
- Added the new-php5-style constructor.
- Just assume md5() supports a second argument, which it does since PHP 5.
- Use the === and !== comparison operators.
- While at it, dropped the fallback to CRYPT_EXT_DES (if there's no working CRYPT_BLOWFISH, fallback to the portable hashes right away).
Testing Instructions
unit tests pass / code review
Documentation Changes Required
none
Note
Remember within Joomla, this is only used to verify then migrate old passwords to the new hashing methods.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | External Library Libraries |
I like the "Dropped PHP 3 & 4 support" changelog
This is now an official phpass release
http://www.openwall.com/lists/announce/2017/05/07/1
@demis-palma @zero-24 please consider reviewing this PR so we can get the PHPASS lib updated.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15704.
@mbabker I think when you restart an appveyor build the build is put back into the bottom of the queued stack as the builds do not run in parallel like they do on travis. This PR currently shows that it has a queued status, so it's "restarted" just pending when it gets to the top of the stack.
@photodude yes, 3.7.2 will only include fixes for regressions or bugs we introduce with 3.7.[0|1]. We still need to stabilize 3.7 so I am not taking any risk on merging other PR
understood, thanks for the explanation.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-05-23 20:05:25 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
?
|
||
Please ignore the php5.6 failure on AppVeyor. One of the required downloads to run SQLSRV seems to be having DNS issues.